[M] Change in dart/sdk[main]: Capture workspace and file status in the log

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Jan 9, 2026, 10:56:04 AM (2 days ago) Jan 9
to Brian Wilkerson, Jake Macdonald, Keerti Parthasarathy, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Jake Macdonald

Brian Wilkerson added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brian Wilkerson . resolved

I'm not sure how to test this, so these changes are completely untested at the moment. I'm happy to test them if there's a good way to do so.

Open in Gerrit

Related details

Attention is currently required from:
  • Jake Macdonald
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If07d20fe61cc3d03167f9a930b67ddd59b8e97e1
Gerrit-Change-Number: 471860
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Jake Macdonald <jak...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jake Macdonald (Gerrit)

unread,
Jan 9, 2026, 11:14:54 AM (2 days ago) Jan 9
to Brian Wilkerson, Keerti Parthasarathy, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Jake Macdonald added 1 comment

File pkg/analysis_server/lib/src/session_logger/session_logger_sink.dart
Line 144, Patchset 1 (Latest): List<int> _getRequestIds(List<LogEntry> entries) {
Jake Macdonald . unresolved

Note that there can be duplicate IDs if the senders are different - probably it should be noted here? Or maybe the function should take a sender ID and only return the IDs where the original request was that sender?

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If07d20fe61cc3d03167f9a930b67ddd59b8e97e1
Gerrit-Change-Number: 471860
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jan 9, 2026, 11:27:54 AM (2 days ago) Jan 9
to Brian Wilkerson, Jake Macdonald, Keerti Parthasarathy, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Brian Wilkerson added 1 comment

Patchset-level comments
Brian Wilkerson . resolved

The failing tests all pass when I run them locally, so I'm not sure why they're failing on the bots.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If07d20fe61cc3d03167f9a930b67ddd59b8e97e1
Gerrit-Change-Number: 471860
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:27:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jan 9, 2026, 1:50:49 PM (2 days ago) Jan 9
to Brian Wilkerson, Jake Macdonald, Keerti Parthasarathy, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Jake Macdonald

Brian Wilkerson voted and added 2 comments

Votes added by Brian Wilkerson

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Brian Wilkerson . resolved

PTAL

File pkg/analysis_server/lib/src/session_logger/session_logger_sink.dart
Line 144, Patchset 1: List<int> _getRequestIds(List<LogEntry> entries) {
Jake Macdonald . resolved

Note that there can be duplicate IDs if the senders are different - probably it should be noted here? Or maybe the function should take a sender ID and only return the IDs where the original request was that sender?

Brian Wilkerson

I added a note to that effect to the doc comment.

I believe that it's currently fine to not pass in a sender because I believe that the only entries that will be in the two lists passed to this method will be from the client. But it's good to document that in case the assumption changes in the future.

Open in Gerrit

Related details

Attention is currently required from:
  • Jake Macdonald
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If07d20fe61cc3d03167f9a930b67ddd59b8e97e1
Gerrit-Change-Number: 471860
Gerrit-PatchSet: 2
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Jake Macdonald <jak...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 18:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jake Macdonald <jak...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Jake Macdonald (Gerrit)

unread,
Jan 9, 2026, 2:23:49 PM (2 days ago) Jan 9
to Brian Wilkerson, Keerti Parthasarathy, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Jake Macdonald voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If07d20fe61cc3d03167f9a930b67ddd59b8e97e1
Gerrit-Change-Number: 471860
Gerrit-PatchSet: 2
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 19:23:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages