[S] Change in dart/sdk[main]: [dart2wasm] Fix --strip-wasm handling in dart compile CLI

0 views
Skip to first unread message

Ömer Ağacan (Gerrit)

unread,
Dec 23, 2025, 6:58:54 AM (yesterday) Dec 23
to Martin Kustermann, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Nate Biggs

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iaa24836a439294badf5470446a2bb83031a79a98
Gerrit-Change-Number: 469582
Gerrit-PatchSet: 3
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 11:58:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ömer Ağacan (Gerrit)

unread,
Dec 23, 2025, 7:00:04 AM (yesterday) Dec 23
to Martin Kustermann, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Nate Biggs

Ömer Ağacan added 1 comment

File pkg/dartdev/lib/src/commands/compile.dart
Line 970, Patchset 3 (Latest): if (!args.flag('strip-wasm')) '--no-strip-wasm',
Ömer Ağacan . unresolved

We could also always pass either `--strip-wasm` or `--no-strip-wasm` based on the value of the flag here. I think it would be slightly better as it wouldn't rely on the default value in dart2wasm CLI. Any thoughts?

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iaa24836a439294badf5470446a2bb83031a79a98
Gerrit-Change-Number: 469582
Gerrit-PatchSet: 3
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 12:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ömer Ağacan (Gerrit)

unread,
Dec 23, 2025, 7:27:30 AM (yesterday) Dec 23
to Martin Kustermann, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Nate Biggs

Ömer Ağacan added 1 comment

File pkg/dartdev/lib/src/commands/compile.dart
Line 970, Patchset 3 (Latest): if (!args.flag('strip-wasm')) '--no-strip-wasm',
Ömer Ağacan . unresolved

We could also always pass either `--strip-wasm` or `--no-strip-wasm` based on the value of the flag here. I think it would be slightly better as it wouldn't rely on the default value in dart2wasm CLI. Any thoughts?

Ömer Ağacan

If we decide to pass one of the two flags always, we should do the same for other flags here, like `minify`, `print-kernel`.

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iaa24836a439294badf5470446a2bb83031a79a98
Gerrit-Change-Number: 469582
Gerrit-PatchSet: 3
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 12:27:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ömer Ağacan <ome...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Ömer Ağacan (Gerrit)

unread,
Dec 23, 2025, 7:28:23 AM (yesterday) Dec 23
to Martin Kustermann, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Nate Biggs

Ömer Ağacan added 1 comment

File pkg/dartdev/lib/src/commands/compile.dart
Line 565, Patchset 3 (Latest): 'Compile to a specific target sanitizer. Sanitizers are not offered with single-file executables because the sanitizers cannot symbolize embedded snapshots.',
Ömer Ağacan . resolved

Note: this change is made by `dart format`.

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iaa24836a439294badf5470446a2bb83031a79a98
Gerrit-Change-Number: 469582
Gerrit-PatchSet: 3
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 12:28:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Biggs (Gerrit)

unread,
Dec 23, 2025, 10:59:40 AM (yesterday) Dec 23
to Ömer Ağacan, Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Ömer Ağacan

Nate Biggs voted and added 1 comment

Votes added by Nate Biggs

Code-Review+1

1 comment

File pkg/dartdev/lib/src/commands/compile.dart
Line 970, Patchset 3 (Latest): if (!args.flag('strip-wasm')) '--no-strip-wasm',
Ömer Ağacan . resolved

We could also always pass either `--strip-wasm` or `--no-strip-wasm` based on the value of the flag here. I think it would be slightly better as it wouldn't rely on the default value in dart2wasm CLI. Any thoughts?

Ömer Ağacan

If we decide to pass one of the two flags always, we should do the same for other flags here, like `minify`, `print-kernel`.

Nate Biggs

Yeah we should probably update these to just pass along the value as-is so that dartdev doesn't have to know the default.

We can do that in a follow-up though.

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
  • Ömer Ağacan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iaa24836a439294badf5470446a2bb83031a79a98
Gerrit-Change-Number: 469582
Gerrit-PatchSet: 3
Gerrit-Owner: Ömer Ağacan <ome...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 15:59:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ömer Ağacan <ome...@google.com>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages