[S] Change in dart/sdk[main]: analyzer: add inference failure tests for dot-shorthands

0 views
Skip to first unread message

Samuel Rawlins (Gerrit)

unread,
Sep 26, 2025, 10:16:13 AM (3 days ago) Sep 26
to Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu

Samuel Rawlins voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kallen Tu
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I84d7f1412b642371b4443d2762d32dfc72c61e45
Gerrit-Change-Number: 451549
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Kallen Tu <kall...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 14:16:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Kallen Tu (Gerrit)

unread,
Sep 26, 2025, 1:38:30 PM (3 days ago) Sep 26
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Kallen Tu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I84d7f1412b642371b4443d2762d32dfc72c61e45
    Gerrit-Change-Number: 451549
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 17:38:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Sep 26, 2025, 2:56:13 PM (3 days ago) Sep 26
    to Samuel Rawlins, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Samuel Rawlins

    Konstantin Shcheglov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Samuel Rawlins
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I84d7f1412b642371b4443d2762d32dfc72c61e45
    Gerrit-Change-Number: 451549
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 18:56:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Sep 26, 2025, 3:26:12 PM (3 days ago) Sep 26
    to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

    Samuel Rawlins voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I84d7f1412b642371b4443d2762d32dfc72c61e45
    Gerrit-Change-Number: 451549
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 19:26:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Sep 26, 2025, 3:33:08 PM (3 days ago) Sep 26
    to Samuel Rawlins, Konstantin Shcheglov, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    analyzer: add inference failure tests for dot-shorthands
    Change-Id: I84d7f1412b642371b4443d2762d32dfc72c61e45
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Kallen Tu <kall...@google.com>
    Commit-Queue: Samuel Rawlins <sraw...@google.com>
    Files:
    • M pkg/analyzer/test/src/diagnostics/inference_failure_on_function_invocation_test.dart
    Change size: S
    Delta: 1 file changed, 27 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kallen Tu, +1 by Konstantin Shcheglov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I84d7f1412b642371b4443d2762d32dfc72c61e45
    Gerrit-Change-Number: 451549
    Gerrit-PatchSet: 2
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages