[M] Change in dart/sdk[main]: analyzer: Remove AnalysisErrorListener and friends
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Oct 20, 2025, 2:48:25 PM (22 hours ago) Oct 20
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Oct 20, 2025, 3:58:05 PM (21 hours ago) Oct 20
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 20, 2025, 3:58:28 PM (21 hours ago) Oct 20
to Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
analyzer: Remove AnalysisErrorListener and friends
* Remove AnalysisErrorListener, `RecordingDiagnosticListener.errors`,
and `RecordingDiagnosticListener.getErrorsForSource`.
* Deprecate `BooleanDiagnosticListener.onError` and
`RecordingDiagnosticListener.onError` in favor of `.onDiagnostic`.
* Deprecate DiagnosticOrErrorListener. Where this class is used in
private API, replace it with DiagnosticListener. Where this class is
used in public API, keep it and ignore the deprecation lint.
Change-Id: Ie9c89008269db8f42e4ebd161df2764d27dfe0da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456100
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analyzer/CHANGELOG.md
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/error/listener.dart
- M pkg/analyzer/lib/src/dart/analysis/file_state.dart
- M pkg/analyzer/lib/src/dart/scanner/scanner.dart
- M pkg/analyzer/lib/src/error/listener.dart
- M pkg/analyzer/lib/src/generated/parser.dart
- M pkg/analyzer/test/error/error_listener_test.dart
- M pkg/analyzer/test/generated/parser_test_base.dart
Change size: M
Delta: 9 files changed, 33 insertions(+), 61 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages