[M] Change in dart/sdk[main]: analyzer: Remove AnalysisErrorListener and friends

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Oct 20, 2025, 2:48:25 PM (22 hours ago) Oct 20
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie9c89008269db8f42e4ebd161df2764d27dfe0da
Gerrit-Change-Number: 456100
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 18:48:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Oct 20, 2025, 3:58:05 PM (21 hours ago) Oct 20
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Samuel Rawlins voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie9c89008269db8f42e4ebd161df2764d27dfe0da
Gerrit-Change-Number: 456100
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 19:58:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Oct 20, 2025, 3:58:28 PM (21 hours ago) Oct 20
to Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
analyzer: Remove AnalysisErrorListener and friends

* Remove AnalysisErrorListener, `RecordingDiagnosticListener.errors`,
and `RecordingDiagnosticListener.getErrorsForSource`.
* Deprecate `BooleanDiagnosticListener.onError` and
`RecordingDiagnosticListener.onError` in favor of `.onDiagnostic`.
* Deprecate DiagnosticOrErrorListener. Where this class is used in
private API, replace it with DiagnosticListener. Where this class is
used in public API, keep it and ignore the deprecation lint.
Change-Id: Ie9c89008269db8f42e4ebd161df2764d27dfe0da
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
  • M pkg/analyzer/CHANGELOG.md
  • M pkg/analyzer/api.txt
  • M pkg/analyzer/lib/error/listener.dart
  • M pkg/analyzer/lib/src/dart/analysis/file_state.dart
  • M pkg/analyzer/lib/src/dart/scanner/scanner.dart
  • M pkg/analyzer/lib/src/error/listener.dart
  • M pkg/analyzer/lib/src/generated/parser.dart
  • M pkg/analyzer/test/error/error_listener_test.dart
  • M pkg/analyzer/test/generated/parser_test_base.dart
Change size: M
Delta: 9 files changed, 33 insertions(+), 61 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie9c89008269db8f42e4ebd161df2764d27dfe0da
Gerrit-Change-Number: 456100
Gerrit-PatchSet: 3
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages