[S] Change in dart/sdk[main]: Keep track of all congiguration messages
0 views
Skip to first unread message
Keerti Parthasarathy (Gerrit)
12:48 PM (8 hours ago) 12:48 PM
to Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
1:01 PM (7 hours ago) 1:01 PM
to Keerti Parthasarathy, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy
Brian Wilkerson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brian Wilkerson . resolved
What's there lgtm, but I suspect we need a slightly bigger change.
File pkg/analysis_server/lib/src/session_logger/session_logger_sink.dart
Line 126, Patchset 1 (Latest):
// This could also provide special handling for `textDocument/didSave`Brian Wilkerson . unresolved
I suspect that for the same reasons the change above is required, this isn't feasible.
It isn't clear to me that we can special-case `didClose` either. And if not, then the `_textDocumentBuffers` can be a list rather than a map, and we'll get more fidelity.
Related details
Attention is currently required from:
- Keerti Parthasarathy
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
4:04 PM (4 hours ago) 4:04 PM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Keerti Parthasarathy added 1 comment![]( "Open in Gerrit")
File pkg/analysis_server/lib/src/session_logger/session_logger_sink.dart
Line 126, Patchset 1 (Latest):
// This could also provide special handling for `textDocument/didSave`Brian Wilkerson . resolved
I suspect that for the same reasons the change above is required, this isn't feasible.
It isn't clear to me that we can special-case `didClose` either. And if not, then the `_textDocumentBuffers` can be a list rather than a map, and we'll get more fidelity.
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
4:04 PM (4 hours ago) 4:04 PM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Keerti Parthasarathy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
4:48 PM (4 hours ago) 4:48 PM
to Keerti Parthasarathy, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analysis_server/lib/src/session_logger/session_logger_sink.dart
Insertions: 4, Deletions: 21.
@@ -61,9 +61,8 @@
/// requested.
final List<LogEntry> _configurationBuffer = [];
- /// A set of buffers, indexed by text document URI, for entries related to
- /// that text document.
- final Map<String, List<LogEntry>> _textDocumentBuffers = {};
+ /// The buffer in which text document related entries are stored.
+ final List<LogEntry> _textDocumentBuffer = [];
/// The buffer in which normal entries are stored.
final List<LogEntry> _sessionBuffer = [];
@@ -79,7 +78,7 @@
return [
..._initializationBuffer,
..._configurationBuffer,
- ..._textDocumentBuffers.values.expand((buffer) => buffer),
+ ..._textDocumentBuffer,
..._sessionBuffer,
];
}
@@ -120,23 +119,7 @@
if (_isConfigurationEntry(logEntry)) {
_configurationBuffer.add(logEntry);
} else if (_isTextDocumentEntry(logEntry)) {
- var message = logEntry.message;
- var textDocumentUri = message.textDocument;
- if (textDocumentUri != null) {
- // This could also provide special handling for `textDocument/didSave`
- // notifications. When the file is saved the player no longer needs to
- // apply any previous edits, so those notifications (and the `didSave`
- // notification itself) could be discarded.
- if (message.isDidClose) {
- _textDocumentBuffers.remove(textDocumentUri);
- } else {
- var buffer = _textDocumentBuffers.putIfAbsent(
- textDocumentUri,
- () => [],
- );
- buffer.add(logEntry);
- }
- }
+ _textDocumentBuffer.add(logEntry);
}
}
}
```
Change information
Commit message:
Keep track of all congiguration messages
Change-Id: I4c546fc13d10adf969a3903b42ea863f0e0cf875
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481181
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/session_logger/session_logger_sink.dart
- M pkg/analysis_server/tool/performance/scenarios/scenario.dart
Change size: M
Delta: 2 files changed, 27 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages