[S] Change in dart/sdk[main]: Implement a visitor method for DotShorthandConstructorInvocation to E...

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Oct 20, 2025, 8:34:37 PM (17 hours ago) Oct 20
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I964b0f8cac2212f730344bf7a19739f0d9effa8b
Gerrit-Change-Number: 456163
Gerrit-PatchSet: 4
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 00:34:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
6:13 AM (7 hours ago) 6:13 AM
to Fedor Shcheglov, Paul Berry, Commit Queue, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov and Paul Berry

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
  • Paul Berry
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I964b0f8cac2212f730344bf7a19739f0d9effa8b
    Gerrit-Change-Number: 456163
    Gerrit-PatchSet: 4
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Comment-Date: Tue, 21 Oct 2025 10:13:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    9:02 AM (4 hours ago) 9:02 AM
    to Fedor Shcheglov, Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov and Paul Berry

    Konstantin Shcheglov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    • Paul Berry
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I964b0f8cac2212f730344bf7a19739f0d9effa8b
    Gerrit-Change-Number: 456163
    Gerrit-PatchSet: 4
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Comment-Date: Tue, 21 Oct 2025 13:02:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    9:02 AM (4 hours ago) 9:02 AM
    to Fedor Shcheglov, Johnni Winther, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    Implement a visitor method for DotShorthandConstructorInvocation to ExitDetector.
    Change-Id: I964b0f8cac2212f730344bf7a19739f0d9effa8b
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Johnni Winther <johnni...@google.com>
    Commit-Queue: Konstantin Shcheglov <sche...@google.com>
    Files:
    • M pkg/analyzer/lib/src/dart/resolver/exit_detector.dart
    • M pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart
    Change size: S
    Delta: 2 files changed, 40 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Johnni Winther, +1 by Konstantin Shcheglov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I964b0f8cac2212f730344bf7a19739f0d9effa8b
    Gerrit-Change-Number: 456163
    Gerrit-PatchSet: 5
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages