[M] Change in dart/sdk[main]: [DAS] Fixes completion for `!=` for dot-shorthand

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Dec 10, 2025, 8:03:57 AM12/10/25
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes completion for `!=`  for dot-shorthand
Change-Id: I35e4884dd0d0db9a27b824ead4ea0232de8171dd

Change information

Files:
  • M pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart
  • M pkg/analysis_server/test/services/completion/dart/location/dot_shorthand_constructor_invocation_test.dart
  • M pkg/analysis_server/test/src/services/completion/dart/feature_computer_test.dart
Change size: M
Delta: 3 files changed, 57 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I35e4884dd0d0db9a27b824ead4ea0232de8171dd
Gerrit-Change-Number: 467320
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 10, 2025, 10:43:53 AM12/10/25
to Felipe Morschel, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Kallen Tu

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
  • Kallen Tu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I35e4884dd0d0db9a27b824ead4ea0232de8171dd
Gerrit-Change-Number: 467320
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Kallen Tu <kall...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Wed, 10 Dec 2025 15:43:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kallen Tu (Gerrit)

unread,
Dec 10, 2025, 10:45:25 AM12/10/25
to Felipe Morschel, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Kallen Tu voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I35e4884dd0d0db9a27b824ead4ea0232de8171dd
    Gerrit-Change-Number: 467320
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Wed, 10 Dec 2025 15:45:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Dec 10, 2025, 11:12:32 AM12/10/25
    to Felipe Morschel, Kallen Tu, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [DAS] Fixes completion for `!=`  for dot-shorthand
    Change-Id: I35e4884dd0d0db9a27b824ead4ea0232de8171dd
    Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Reviewed-by: Kallen Tu <kall...@google.com>
    Commit-Queue: Kallen Tu <kall...@google.com>
    Commit-Queue: Samuel Rawlins <sraw...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart
    • M pkg/analysis_server/test/services/completion/dart/location/dot_shorthand_constructor_invocation_test.dart
    • M pkg/analysis_server/test/src/services/completion/dart/feature_computer_test.dart
    Change size: M
    Delta: 3 files changed, 57 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Kallen Tu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I35e4884dd0d0db9a27b824ead4ea0232de8171dd
    Gerrit-Change-Number: 467320
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages