[M] Change in dart/sdk[main]: [vm] Remove helpers for pre-C++11 64-bit literals.

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
4:51 PM (4 hours ago) 4:51 PM
to Alexander Markov, Commit Queue, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icb198c9d0eb11c11f9fa61f41c37c8705f68001c
Gerrit-Change-Number: 481165
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Tue, 17 Feb 2026 21:51:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
5:00 PM (4 hours ago) 5:00 PM
to Ryan Macnak, Alexander Markov, Commit Queue, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak

Alexander Markov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icb198c9d0eb11c11f9fa61f41c37c8705f68001c
Gerrit-Change-Number: 481165
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 17 Feb 2026 22:00:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
5:14 PM (3 hours ago) 5:14 PM
to Alexander Markov, Commit Queue, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icb198c9d0eb11c11f9fa61f41c37c8705f68001c
Gerrit-Change-Number: 481165
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 17 Feb 2026 22:14:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
5:15 PM (3 hours ago) 5:15 PM
to Ryan Macnak, Alexander Markov, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[vm] Remove helpers for pre-C++11 64-bit literals.

TEST=ci
Change-Id: Icb198c9d0eb11c11f9fa61f41c37c8705f68001c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481165
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
  • M runtime/platform/globals.h
  • M runtime/vm/compiler/assembler/assembler_arm64_test.cc
  • M runtime/vm/dart_api_impl_test.cc
  • M runtime/vm/double_internals.h
  • M runtime/vm/globals.h
  • M runtime/vm/object.h
  • M runtime/vm/object_test.cc
  • M runtime/vm/snapshot_test.cc
  • M runtime/vm/unicode.cc
  • M runtime/vm/utils_test.cc
Change size: M
Delta: 10 files changed, 44 insertions(+), 66 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Markov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Icb198c9d0eb11c11f9fa61f41c37c8705f68001c
Gerrit-Change-Number: 481165
Gerrit-PatchSet: 4
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages