[L] Change in dart/sdk[main]: [vm/aot] Improve dynamic interface annotator
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Jul 26, 2024, 5:32:46 PM7/26/24
to Alexander Markov, Slava Egorov, Sigmund Cherem, Commit Queue, Jens Johansen, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Sigmund Cherem and Slava Egorov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Sigmund Cherem
- Slava Egorov
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Jul 30, 2024, 8:30:33 AM7/30/24
to Alexander Markov, Sigmund Cherem, Commit Queue, Jens Johansen, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Sigmund Cherem
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
- Sigmund Cherem
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Jul 30, 2024, 10:35:07 AM7/30/24
to Alexander Markov, Slava Egorov, Sigmund Cherem, Commit Queue, Jens Johansen, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Sigmund Cherem
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sigmund Cherem
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Jul 30, 2024, 12:24:39 PM7/30/24
to Alexander Markov, Slava Egorov, Sigmund Cherem, Commit Queue, Jens Johansen, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Sigmund Cherem
Alexander Markov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Sigmund Cherem
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jul 30, 2024, 12:24:56 PM7/30/24
to Alexander Markov, Slava Egorov, Sigmund Cherem, Jens Johansen, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm/aot] Improve dynamic interface annotator
Dynamic interface annotator now automatically annotates classes and
members which are used implicitly:
* Targets of redirecting factories.
* Classes and members used in constants.
* Instance fields of classes used in instance constants or
having a callable const constructor.
* Everything used in the bodies of extendable mixin declarations and
mixin classes.
* Possible dispatch targets of instance calls
(overrides/implementations).
Front-end server now also exposes '--dynamic-interface' option,
similar to gen_kernel tool.
Also, this change includes a couple of minor fixes:
* Typo in ast.dart.
* In the front-end server, additional dill file specified with
'--import-dill' option is not ignored when '--link-platform' is
also used.
TEST=pkg/vm/testcases/transformations/dynamic_interface_annotator
Change-Id: I705b64efb1834dec6e0bdc5873025607f3472139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377761
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M pkg/frontend_server/lib/frontend_server.dart
- M pkg/kernel/lib/ast.dart
- M pkg/vm/lib/transformations/dynamic_interface_annotator.dart
- M pkg/vm/lib/transformations/pragma.dart
- M pkg/vm/testcases/transformations/dynamic_interface_annotator/lib1.dart
- M pkg/vm/testcases/transformations/dynamic_interface_annotator/lib1.dart.expect
- M pkg/vm/testcases/transformations/dynamic_interface_annotator/lib2.dart
- M pkg/vm/testcases/transformations/dynamic_interface_annotator/lib2.dart.expect
- M runtime/vm/object.cc
- M runtime/vm/symbols.h
Change size: L
Delta: 10 files changed, 608 insertions(+), 74 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigmund Cherem (Gerrit)
Jul 30, 2024, 1:50:31 PM7/30/24
to Alexander Markov, Commit Queue, Sigmund Cherem, Slava Egorov, Jens Johansen, rev...@dartlang.org, vm-...@dartlang.org
Sigmund Cherem voted Code-Review+1![]( "Open in Gerrit")
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages