[M] Change in dart/sdk[main]: Fix a crash resulting from synthetic named formal parameters inside r...

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Dec 30, 2025, 6:19:47 PM (12 hours ago) Dec 30
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie53cbcec9242bf0aa0225e74cf2879f9c0f183ac
Gerrit-Change-Number: 470122
Gerrit-PatchSet: 10
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Dec 2025 23:19:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 30, 2025, 6:39:08 PM (12 hours ago) Dec 30
to Fedor Shcheglov, Commit Queue, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov and Konstantin Shcheglov

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
  • Konstantin Shcheglov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie53cbcec9242bf0aa0225e74cf2879f9c0f183ac
    Gerrit-Change-Number: 470122
    Gerrit-PatchSet: 10
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Comment-Date: Tue, 30 Dec 2025 23:39:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Dec 30, 2025, 6:41:46 PM (12 hours ago) Dec 30
    to Fedor Shcheglov, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov and Samuel Rawlins

    Konstantin Shcheglov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    • Samuel Rawlins
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie53cbcec9242bf0aa0225e74cf2879f9c0f183ac
      Gerrit-Change-Number: 470122
      Gerrit-PatchSet: 11
      Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
      Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
      Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
      Gerrit-Comment-Date: Tue, 30 Dec 2025 23:41:43 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Samuel Rawlins (Gerrit)

      unread,
      Dec 30, 2025, 7:15:01 PM (11 hours ago) Dec 30
      to Fedor Shcheglov, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
      Attention needed from Fedor Shcheglov and Konstantin Shcheglov

      Samuel Rawlins voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fedor Shcheglov
      • Konstantin Shcheglov
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie53cbcec9242bf0aa0225e74cf2879f9c0f183ac
        Gerrit-Change-Number: 470122
        Gerrit-PatchSet: 11
        Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
        Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
        Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
        Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Comment-Date: Wed, 31 Dec 2025 00:14:58 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Konstantin Shcheglov (Gerrit)

        unread,
        Dec 30, 2025, 7:15:24 PM (11 hours ago) Dec 30
        to Fedor Shcheglov, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

        Konstantin Shcheglov submitted the change

        Change information

        Commit message:
        Fix a crash resulting from synthetic named formal parameters inside redirecting constructors.
        Change-Id: Ie53cbcec9242bf0aa0225e74cf2879f9c0f183ac
        Reviewed-by: Samuel Rawlins <sraw...@google.com>
        Reviewed-by: Konstantin Shcheglov <sche...@google.com>
        Files:
        • M pkg/analyzer/lib/src/error/unused_local_elements_verifier.dart
        • M pkg/analyzer/test/src/diagnostics/unused_element_test.dart
        Change size: M
        Delta: 2 files changed, 56 insertions(+), 24 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie53cbcec9242bf0aa0225e74cf2879f9c0f183ac
        Gerrit-Change-Number: 470122
        Gerrit-PatchSet: 12
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages