[XS] Change in dart/sdk[main]: [deps] rev tools to 119a499068a903222fbbefdea18ea59efdd417b9

0 views
Skip to first unread message

Danny Tuppeny (Gerrit)

unread,
7:09 AM (13 hours ago) 7:09 AM
to Brian Wilkerson, Konstantin Shcheglov, rev...@dartlang.org
Attention needed from Brian Wilkerson and Konstantin Shcheglov

Danny Tuppeny added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Danny Tuppeny . resolved

This gets the latest test_reflective_loader that has some changes I made recently.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
Gerrit-Change-Number: 481120
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Tue, 17 Feb 2026 12:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
10:23 AM (10 hours ago) 10:23 AM
to Danny Tuppeny, Brian Wilkerson, Konstantin Shcheglov, rev...@dartlang.org
Attention needed from Danny Tuppeny and Konstantin Shcheglov

Brian Wilkerson voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
  • Konstantin Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
Gerrit-Change-Number: 481120
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Tue, 17 Feb 2026 15:23:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
12:12 PM (8 hours ago) 12:12 PM
to Danny Tuppeny, Commit Queue, Brian Wilkerson, rev...@dartlang.org
Attention needed from Brian Wilkerson and Danny Tuppeny

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Danny Tuppeny
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
    Gerrit-Change-Number: 481120
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 17:12:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Danny Tuppeny (Gerrit)

    unread,
    12:16 PM (8 hours ago) 12:16 PM
    to Konstantin Shcheglov, Commit Queue, Brian Wilkerson, rev...@dartlang.org
    Attention needed from Brian Wilkerson

    Danny Tuppeny added 1 comment

    Patchset-level comments
    Danny Tuppeny . resolved

    Not a priority, but could someone check the g3 failures when time?

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
    Gerrit-Change-Number: 481120
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 17:16:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    12:24 PM (8 hours ago) 12:24 PM
    to Danny Tuppeny, Samuel Rawlins, Konstantin Shcheglov, Commit Queue, Brian Wilkerson, rev...@dartlang.org
    Attention needed from Danny Tuppeny and Samuel Rawlins

    Brian Wilkerson added 1 comment

    Patchset-level comments
    Brian Wilkerson . resolved

    The tests are failing because `null` is being returned in some situation where it wasn't before. I'm not familiar enough with the tests to understand what's returning the `null` or why that would have changed, so I added Sam, hoping that he could take a look at it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danny Tuppeny
    • Samuel Rawlins
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
    Gerrit-Change-Number: 481120
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 17:24:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    12:59 PM (8 hours ago) 12:59 PM
    to Danny Tuppeny, Konstantin Shcheglov, Commit Queue, Brian Wilkerson, rev...@dartlang.org
    Attention needed from Danny Tuppeny

    Samuel Rawlins added 1 comment

    Patchset-level comments
    Brian Wilkerson . unresolved

    The tests are failing because `null` is being returned in some situation where it wasn't before. I'm not familiar enough with the tests to understand what's returning the `null` or why that would have changed, so I added Sam, hoping that he could take a look at it.

    Samuel Rawlins

    I'm looking into it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danny Tuppeny
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
    Gerrit-Change-Number: 481120
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 17:59:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    1:22 PM (7 hours ago) 1:22 PM
    to Danny Tuppeny, Konstantin Shcheglov, Commit Queue, Brian Wilkerson, rev...@dartlang.org
    Attention needed from Danny Tuppeny

    Samuel Rawlins added 1 comment

    Patchset-level comments
    Brian Wilkerson . unresolved

    The tests are failing because `null` is being returned in some situation where it wasn't before. I'm not familiar enough with the tests to understand what's returning the `null` or why that would have changed, so I added Sam, hoping that he could take a look at it.

    Samuel Rawlins

    I'm looking into it.

    Samuel Rawlins

    I strongly suspect a5ce342250471a7c0afc433c68fe95c87d67a7c3 (https://dart-review.googlesource.com/c/sdk/+/480980) which landed just before this, and has changes to package:record_use.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danny Tuppeny
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
    Gerrit-Change-Number: 481120
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 18:22:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
    Comment-In-Reply-To: Samuel Rawlins <sraw...@google.com>
    satisfied_requirement
    open
    diffy

    Danny Tuppeny (Gerrit)

    unread,
    1:26 PM (7 hours ago) 1:26 PM
    to Samuel Rawlins, Konstantin Shcheglov, Commit Queue, Brian Wilkerson, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Samuel Rawlins

    Danny Tuppeny added 1 comment

    Patchset-level comments
    Brian Wilkerson . unresolved

    The tests are failing because `null` is being returned in some situation where it wasn't before. I'm not familiar enough with the tests to understand what's returning the `null` or why that would have changed, so I added Sam, hoping that he could take a look at it.

    Samuel Rawlins

    I'm looking into it.

    Samuel Rawlins

    I strongly suspect a5ce342250471a7c0afc433c68fe95c87d67a7c3 (https://dart-review.googlesource.com/c/sdk/+/480980) which landed just before this, and has changes to package:record_use.

    Danny Tuppeny

    Thanks! I do see some red appearing on the dashboard too. Let's wait until that's resolved and then rebase and try again then.

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Samuel Rawlins
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I98414cb639590e2c29bd8d26d6c0f6fa56334c2e
    Gerrit-Change-Number: 481120
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 18:26:13 +0000
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages