[S] Change in dart/sdk[main]: CQ. Fix NPE in DartUnitOccurrencesComputerVisitor when unresolved imp...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Oct 20, 2025, 6:08:39 PM (19 hours ago) Oct 20
to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Oct 20, 2025, 6:16:32 PM (19 hours ago) Oct 20
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Oct 20, 2025, 7:31:59 PM (18 hours ago) Oct 20
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 20, 2025, 7:32:19 PM (18 hours ago) Oct 20
to Konstantin Shcheglov, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CQ. Fix NPE in DartUnitOccurrencesComputerVisitor when unresolved import prefix.
Saw a crash in logs:
Null check operator used on a null value
package:analysis_server/src/domains/analysis/occurrences_dart.dart 253:32 DartUnitOccurrencesComputerVisitor.visitImportPrefixReference
package:analyzer/src/dart/ast/ast.dart 13353:15 ImportPrefixReferenceImpl.accept
package:analyzer/src/dart/ast/ast.dart 16897:19 NamedTypeImpl.visitChildren
package:analyzer/dart/ast/visitor.g.dart 474:10 GeneralizingAstVisitor.visitNode
package:analyzer/dart/ast/visitor.g.dart 687:50 GeneralizingAstVisitor.visitTypeAnnotation
package:analyzer/dart/ast/visitor.g.dart 456:40 GeneralizingAstVisitor.visitNamedType
package:analysis_server/src/domains/analysis/occurrences_dart.dart 282:11 DartUnitOccurrencesComputerVisitor.visitNamedType
Change-Id: I2b06026dad093187c74b4e1b6c7371aaf648a480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456121
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart
- M pkg/analysis_server/test/analysis/notification_occurrences_test.dart
Change size: S
Delta: 2 files changed, 12 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages