[M] Change in dart/sdk[main]: [ Service ] Fix dart:developer service extensions, add getSupportedPr...

0 views
Skip to first unread message

Ben Konyi (Gerrit)

unread,
Mar 12, 2026, 3:04:10 PMMar 12
to Jessy Yameogo, Nicholas Shahan, Mark Zhou, Srujan Gaddam, rev...@dartlang.org
Attention needed from Jessy Yameogo and Nicholas Shahan

Ben Konyi voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jessy Yameogo
  • Nicholas Shahan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I108a24e1acf37eb69c9de25a2f7334eb4c56dbe6
Gerrit-Change-Number: 487600
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Mark Zhou <mark...@google.com>
Gerrit-CC: Srujan Gaddam <sru...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Attention: Nicholas Shahan <nsh...@google.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 19:04:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Shahan (Gerrit)

unread,
Mar 13, 2026, 5:08:54 PMMar 13
to Ben Konyi, Commit Queue, Jessy Yameogo, Mark Zhou, Srujan Gaddam, rev...@dartlang.org
Attention needed from Ben Konyi and Jessy Yameogo

Nicholas Shahan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Jessy Yameogo
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I108a24e1acf37eb69c9de25a2f7334eb4c56dbe6
Gerrit-Change-Number: 487600
Gerrit-PatchSet: 3
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Mark Zhou <mark...@google.com>
Gerrit-CC: Srujan Gaddam <sru...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 21:08:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ben Konyi (Gerrit)

unread,
Mar 16, 2026, 1:41:06 PMMar 16
to Nicholas Shahan, Commit Queue, Jessy Yameogo, Mark Zhou, Srujan Gaddam, rev...@dartlang.org
Attention needed from Jessy Yameogo

Ben Konyi voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jessy Yameogo
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I108a24e1acf37eb69c9de25a2f7334eb4c56dbe6
Gerrit-Change-Number: 487600
Gerrit-PatchSet: 4
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Mark Zhou <mark...@google.com>
Gerrit-CC: Srujan Gaddam <sru...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 17:41:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 16, 2026, 2:15:02 PMMar 16
to Ben Konyi, Nicholas Shahan, Jessy Yameogo, Mark Zhou, Srujan Gaddam, rev...@dartlang.org

Commit Queue submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[ Service ] Fix dart:developer service extensions, add getSupportedProtocols

Brings package:vm_service test suite pass rate up to ~93%
Change-Id: I108a24e1acf37eb69c9de25a2f7334eb4c56dbe6
Reviewed-by: Nicholas Shahan <nsh...@google.com>
Commit-Queue: Ben Konyi <bko...@google.com>
Files:
  • M pkg/dart_runtime_service/lib/dart_runtime_service.dart
  • M pkg/dart_runtime_service/lib/src/clients.dart
  • M pkg/dart_runtime_service/lib/src/dart_runtime_service_backend.dart
  • M pkg/dart_runtime_service/lib/src/dart_runtime_service_rpcs.dart
  • M pkg/dart_runtime_service/test/utils/mocks.dart
  • M pkg/dart_runtime_service_vm/lib/dart_runtime_service_vm.dart
  • A pkg/dart_runtime_service_vm/lib/src/dart_runtime_service_vm_rpcs.dart
  • M pkg/dart_runtime_service_vm/lib/src/native_bindings.dart
Change size: M
Delta: 8 files changed, 120 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nicholas Shahan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I108a24e1acf37eb69c9de25a2f7334eb4c56dbe6
Gerrit-Change-Number: 487600
Gerrit-PatchSet: 5
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages