Groups keyboard shortcuts have been updated

Dismiss

See shortcuts

[M] Change in dart/sdk[main]: [cq] Reduce assignments to testCode to 1

0 views

Skip to first unread message

Brian Wilkerson (Gerrit)

unread,

Mar 14, 2025, 5:49:52 PMMar 14

to Brian Wilkerson, Samuel Rawlins, Felipe Morschel, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Samuel Rawlins

Brian Wilkerson voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Samuel Rawlins

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Mar 14, 2025, 8:38:54 PMMar 14

to Brian Wilkerson, Felipe Morschel, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Samuel Rawlins . resolved

This all looks very clean to me.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Mar 15, 2025, 10:34:20 AMMar 15

to Brian Wilkerson, Samuel Rawlins, Felipe Morschel, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Brian Wilkerson voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Commit Queue (Gerrit)

unread,

Mar 15, 2025, 10:34:34 AMMar 15

to Brian Wilkerson, Samuel Rawlins, Felipe Morschel, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:

[cq] Reduce assignments to testCode to 1

The purpose for this change is to make it easier to use `TestCode` to
parse the code under test. This, in turn, will allow us to use the same
markdown in all of our test code, making it easier to write and read
our tests. This biggest blocker to that goal is the fact that we assign
to `testCode` in several places, and that's the problem solved by this
change.

Change-Id: Id88463925587ff0839fe75faf6a1d083a1b3320c

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415700

Reviewed-by: Samuel Rawlins <sraw...@google.com>

Commit-Queue: Brian Wilkerson <brianwi...@google.com>

Files:

M pkg/analysis_server/test/abstract_single_unit.dart
M pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart
M pkg/analysis_server/test/services/correction/organize_directives_test.dart
M pkg/analysis_server/test/services/refactoring/legacy/rename_parameter_test.dart
M pkg/analysis_server/test/src/services/correction/fix/import_library_project_test.dart

Change size: M

Delta: 5 files changed, 72 insertions(+), 104 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Samuel Rawlins

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages