[S] Change in dart/sdk[main]: Fine. Fix for withFineDependencies value in analytics in long sessions.
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Oct 30, 2025, 4:14:33 PM (6 days ago) Oct 30
to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Oct 30, 2025, 4:50:08 PM (6 days ago) Oct 30
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Konstantin Shcheglov . resolved
I missed the test, updated now. PTAL
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Oct 30, 2025, 5:43:39 PM (6 days ago) Oct 30
to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Oct 30, 2025, 5:45:01 PM (6 days ago) Oct 30
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 30, 2025, 5:45:15 PM (6 days ago) Oct 30
to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fine. Fix for withFineDependencies value in analytics in long sessions.
Change-Id: I7bde7585503197f4dc490b09cea9a96dac565597
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458624
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/analytics/analytics_manager.dart
- M pkg/analysis_server/test/src/analytics/analytics_manager_test.dart
- M pkg/analyzer/lib/src/dart/analysis/driver.dart
Change size: S
Delta: 3 files changed, 15 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages