[XS] Change in dart/sdk[main]: [dart2wasm] Don't clone async function contexts

0 views

Skip to first unread message

Ömer Ağacan (Gerrit)

unread,

Dec 30, 2025, 6:16:20 AM (24 hours ago) Dec 30

to Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org

Attention needed from Martin Kustermann

Ömer Ağacan added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Ömer Ağacan . resolved

@kuste...@google.com I tried to understand what this cloning is about from the tests and commits that added it. Let me know if I misunderstood, and we should add a test instead that will break with this CL.

Open in Gerrit

Related details

Attention is currently required from:

Martin Kustermann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ömer Ağacan (Gerrit)

unread,

Dec 30, 2025, 9:28:13 AM (21 hours ago) Dec 30

to Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org

Attention needed from Martin Kustermann

Ömer Ağacan added 1 comment

File pkg/dart2wasm/lib/async.dart

Line 241, Patchset 3 (Latest): // Clone context on first execution.

Ömer Ağacan . unresolved

TODO: Remove comment