[XS] Change in dart/sdk[main]: [co19] Roll co19 to ac779cf0ef7215bc226d00af16f31fe35b1850f5

0 views
Skip to first unread message

Sergey Grekhov (Gerrit)

unread,
4:00 AM (12 hours ago) 4:00 AM
to Alexander Thomas, Erik Ernst, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov has uploaded the change for review

Sergey Grekhov would like Alexander Thomas and Erik Ernst to review this change.

Commit message

[co19] Roll co19 to ac779cf0ef7215bc226d00af16f31fe35b1850f5

2026-02-12 sgrek...@gmail.com dart-lang/co19#3182. Fix/update tests for primary constructors (dart-lang/co19#3616)
2026-02-11 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmentation of primary constructors. Part 2. (dart-lang/co19#3611)
2026-02-11 sgrek...@gmail.com Fixes dart-lang/co19#3612. Replace WARNING.X_Y_Z by STATIC_STATIC_WARNING.X_Y_Z (dart-lang/co19#3613)
2026-02-10 sgrek...@gmail.com dart-lang/co19#3608. Update primary constructor tests (dart-lang/co19#3610)
2026-02-10 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmenting primary constructors (dart-lang/co19#3606)
2026-02-10 sgrek...@gmail.com dart-lang/co19#3182. Remove duplicated tests for extension types (dart-lang/co19#3609)
2026-02-09 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmentation of primary constructors (dart-lang/co19#3607)
2026-02-06 sgrek...@gmail.com dart-lang/co19#3182. Update `extension_types_*.dart` tests (dart-lang/co19#3462)
2026-02-06 sgrek...@gmail.com dart-lang/co19#3182. Add new test for `async`, `async*` and `sync*` functions (dart-lang/co19#3568)
2026-02-06 sgrek...@gmail.com dart-lang/co19#3602. Add more tests for primary constructors (dart-lang/co19#3603)

R=at...@google.com, eer...@google.com
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2

Change information

Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
Gerrit-Change-Number: 480920
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
4:08 AM (12 hours ago) 4:08 AM
to Sergey Grekhov, Chloe Stefantsova, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas, Chloe Stefantsova and Sergey Grekhov

Erik Ernst voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Chloe Stefantsova
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
Gerrit-Change-Number: 480920
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Comment-Date: Mon, 16 Feb 2026 09:08:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
4:21 AM (12 hours ago) 4:21 AM
to Sergey Grekhov, Chloe Stefantsova, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas, Erik Ernst and Sergey Grekhov

Erik Ernst removed Chloe Stefantsova from this change

Deleted Reviewers:
  • Chloe Stefantsova
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
Gerrit-Change-Number: 480920
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
4:21 AM (12 hours ago) 4:21 AM
to Sergey Grekhov, Alexander Thomas, Commit Queue, rev...@dartlang.org
Attention needed from Erik Ernst and Sergey Grekhov

Erik Ernst removed Alexander Thomas from this change

Deleted Reviewers:
  • Alexander Thomas
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Ernst
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
Gerrit-Change-Number: 480920
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
4:38 AM (12 hours ago) 4:38 AM
to Sergey Grekhov, Commit Queue, Erik Ernst, rev...@dartlang.org
Attention needed from Erik Ernst and Sergey Grekhov

Johnni Winther voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Ernst
  • Sergey Grekhov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
    Gerrit-Change-Number: 480920
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Attention: Erik Ernst <eer...@google.com>
    Gerrit-Comment-Date: Mon, 16 Feb 2026 09:38:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Erik Ernst (Gerrit)

    unread,
    5:35 AM (11 hours ago) 5:35 AM
    to Sergey Grekhov, Alexander Thomas, Johnni Winther, Commit Queue, rev...@dartlang.org
    Attention needed from Alexander Thomas, Johnni Winther and Sergey Grekhov

    Erik Ernst voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Thomas
    • Johnni Winther
    • Sergey Grekhov
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
      Gerrit-Change-Number: 480920
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
      Gerrit-Reviewer: Alexander Thomas <at...@google.com>
      Gerrit-Reviewer: Erik Ernst <eer...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
      Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
      Gerrit-Attention: Alexander Thomas <at...@google.com>
      Gerrit-Attention: Johnni Winther <johnni...@google.com>
      Gerrit-Comment-Date: Mon, 16 Feb 2026 10:35:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sergey Grekhov (Gerrit)

      unread,
      6:59 AM (9 hours ago) 6:59 AM
      to Erik Ernst, Alexander Thomas, Johnni Winther, Commit Queue, rev...@dartlang.org
      Attention needed from Alexander Thomas, Erik Ernst, Johnni Winther and Sergey Grekhov

      Sergey Grekhov voted and added 1 comment

      Votes added by Sergey Grekhov

      Auto-Submit+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 2 (Latest):
      Sergey Grekhov . resolved

      Can be landed.
      co19/LanguageFeatures/Primary-constructors/static_processing_A25_t05 - https://github.com/dart-lang/sdk/issues/62687
      co19/LanguageFeatures/Primary-constructors/static_processing_A14_t03 -
      https://github.com/dart-lang/sdk/issues/62627

      All other failures caused by test for augmentations. This feature is not implemented yet

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alexander Thomas
      • Erik Ernst
      • Johnni Winther
      • Sergey Grekhov
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
      Gerrit-Change-Number: 480920
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
      Gerrit-Reviewer: Alexander Thomas <at...@google.com>
      Gerrit-Reviewer: Erik Ernst <eer...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
      Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
      Gerrit-Attention: Alexander Thomas <at...@google.com>
      Gerrit-Attention: Erik Ernst <eer...@google.com>
      Gerrit-Attention: Johnni Winther <johnni...@google.com>
      Gerrit-Comment-Date: Mon, 16 Feb 2026 11:59:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Johnni Winther (Gerrit)

      unread,
      12:17 PM (4 hours ago) 12:17 PM
      to Sergey Grekhov, Erik Ernst, Alexander Thomas, Commit Queue, rev...@dartlang.org
      Attention needed from Alexander Thomas and Sergey Grekhov

      Johnni Winther voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alexander Thomas
      • Sergey Grekhov
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
        Gerrit-Change-Number: 480920
        Gerrit-PatchSet: 2
        Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
        Gerrit-Reviewer: Alexander Thomas <at...@google.com>
        Gerrit-Reviewer: Erik Ernst <eer...@google.com>
        Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
        Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
        Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
        Gerrit-Attention: Alexander Thomas <at...@google.com>
        Gerrit-Comment-Date: Mon, 16 Feb 2026 17:17:19 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Commit Queue (Gerrit)

        unread,
        12:17 PM (4 hours ago) 12:17 PM
        to Sergey Grekhov, Johnni Winther, Erik Ernst, Alexander Thomas, rev...@dartlang.org

        Commit Queue submitted the change

        Change information

        Commit message:
        [co19] Roll co19 to ac779cf0ef7215bc226d00af16f31fe35b1850f5

        2026-02-12 sgrek...@gmail.com dart-lang/co19#3182. Fix/update tests for primary constructors (dart-lang/co19#3616)
        2026-02-11 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmentation of primary constructors. Part 2. (dart-lang/co19#3611)
        2026-02-11 sgrek...@gmail.com Fixes dart-lang/co19#3612. Replace WARNING.X_Y_Z by STATIC_STATIC_WARNING.X_Y_Z (dart-lang/co19#3613)
        2026-02-10 sgrek...@gmail.com dart-lang/co19#3608. Update primary constructor tests (dart-lang/co19#3610)
        2026-02-10 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmenting primary constructors (dart-lang/co19#3606)
        2026-02-10 sgrek...@gmail.com dart-lang/co19#3182. Remove duplicated tests for extension types (dart-lang/co19#3609)
        2026-02-09 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmentation of primary constructors (dart-lang/co19#3607)
        2026-02-06 sgrek...@gmail.com dart-lang/co19#3182. Update `extension_types_*.dart` tests (dart-lang/co19#3462)
        2026-02-06 sgrek...@gmail.com dart-lang/co19#3182. Add new test for `async`, `async*` and `sync*` functions (dart-lang/co19#3568)
        2026-02-06 sgrek...@gmail.com dart-lang/co19#3602. Add more tests for primary constructors (dart-lang/co19#3603)

        R=at...@google.com, eer...@google.com
        Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
        Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
        Commit-Queue: Johnni Winther <johnni...@google.com>
        Reviewed-by: Erik Ernst <eer...@google.com>
        Auto-Submit: Sergey Grekhov <sgrek...@gmail.com>
        Reviewed-by: Johnni Winther <johnni...@google.com>
        Files:
        • M DEPS
        • M tests/co19/co19-dart2js.status
        • M tests/co19/co19-dartdevc.status
        Change size: XS
        Delta: 3 files changed, 3 insertions(+), 1 deletion(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Erik Ernst, +1 by Johnni Winther
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: I42f2f90acd34e02bc8ecdae34ee1b46bf699a2c2
        Gerrit-Change-Number: 480920
        Gerrit-PatchSet: 3
        Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
        Gerrit-Reviewer: Alexander Thomas <at...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages