[XS] Change in dart/sdk[main]: [vm] Improve packing of Sample.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Nov 4, 2025, 5:40:35 PM (2 days ago) Nov 4
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
Ryan Macnak added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Ryan Macnak . resolved
BEFORE
```
(gdb) ptype /o dart::Sample
/* offset | size */ type = class dart::Sample {
public:
static const int kPCArraySizeInWords;
static const int kStackBufferSizeInWords;
private:
/* 0 | 8 */ int64_t timestamp_;
/* 8 | 8 */ Dart_Port port_;
/* 16 | 8 */ dart::ThreadId tid_;
/* 24 | 16 */ dart::uword stack_buffer_[2];
/* 40 | 256 */ dart::uword pc_array_[32];
/* 296 | 8 */ dart::uword vm_tag_;
/* 304 | 8 */ dart::uword user_tag_;
/* 312 | 4 */ uint32_t state_;
/* XXX 4-byte hole */
/* 320 | 8 */ dart::Sample *next_;
/* 328 | 4 */ uint32_t allocation_identity_hash_;
/* XXX 4-byte padding */
/* total size (bytes): 336 */
}
```
AFTER
```
(gdb) ptype /o dart::Sample
/* offset | size */ type = class dart::Sample {
public:
static const int kPCArraySizeInWords;
static const int kStackBufferSizeInWords;
private:
/* 0 | 8 */ int64_t timestamp_;
/* 8 | 8 */ Dart_Port port_;
/* 16 | 8 */ dart::ThreadId tid_;
/* 24 | 16 */ dart::uword stack_buffer_[2];
/* 40 | 256 */ dart::uword pc_array_[32];
/* 296 | 8 */ dart::uword vm_tag_;
/* 304 | 8 */ dart::uword user_tag_;
/* 312 | 8 */ dart::Sample *next_;
/* 320 | 4 */ uint32_t state_;
/* 324 | 4 */ uint32_t allocation_identity_hash_;
/* total size (bytes): 328 */
}
```
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Nov 4, 2025, 5:42:02 PM (2 days ago) Nov 4
to Ryan Macnak, Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Nov 4, 2025, 6:13:56 PM (2 days ago) Nov 4
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Nov 4, 2025, 6:14:16 PM (2 days ago) Nov 4
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Improve packing of Sample.
TEST=ci
Change-Id: Iad37e5f7331d731f4bf0ec9978ac1d06dd8693d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459640
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Files:
- M runtime/vm/profiler.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages