[M] Change in dart/sdk[main]: [DAS] Fixes primary constructor body completion
1 view
Skip to first unread message
FMorschel (Gerrit)
Aug 4, 2026, 12:03:13 PM (yesterday) Aug 4
to dart-analys...@google.com, rev...@dartlang.org
FMorschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[DAS] Fixes primary constructor body completion
Change-Id: I1de0af89174065d5c24d4dd2d8009a58bdb1be8c
Change information
Files:
- M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
- M pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
- M pkg/analysis_server/test/services/completion/dart/location/primary_constructor_declaration_test.dart
Change size: M
Delta: 3 files changed, 58 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Aug 4, 2026, 12:53:33 PM (yesterday) Aug 4
to FMorschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from FMorschel and Samuel Rawlins
Brian Wilkerson added 2 comments![]( "Open in Gerrit")
File pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
Line 1270, Patchset 1 (Latest):
case FieldDeclaration():Brian Wilkerson . resolved
This is probably where https://github.com/dart-lang/sdk/issues/63931 needs to be fixed.
Line 2713, Patchset 1 (Latest):
_suggestParameter(declaredElement);Brian Wilkerson . unresolved
This looks wrong. It looks like we will suggest both the field and the parameter when it's a field formal parameter. But only one name is visible in any given scope, so we should have logic here to determine which it is.
Related details
Attention is currently required from:
- FMorschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
FMorschel (Gerrit)
Aug 4, 2026, 6:52:59 PM (yesterday) Aug 4
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
FMorschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by FMorschel
| Auto-Submit | +1 |
1 comment
File pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
Line 2713, Patchset 1:
_suggestParameter(declaredElement);Brian Wilkerson . resolved
FMorschelThis looks wrong. It looks like we will suggest both the field and the parameter when it's a field formal parameter. But only one name is visible in any given scope, so we should have logic here to determine which it is.
Oh, thanks! It would hide it because of the name clash, but yes, I was missing an `else` here.
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Aug 4, 2026, 7:11:01 PM (24 hours ago) Aug 4
to FMorschel, Keerti Parthasarathy, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from FMorschel and Keerti Parthasarathy
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- FMorschel
- Keerti Parthasarathy
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
1:55 PM (5 hours ago) 1:55 PM
to FMorschel, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Related details
Attention is currently required from:
- FMorschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
1:55 PM (5 hours ago) 1:55 PM
to FMorschel, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from FMorschel
Keerti Parthasarathy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- FMorschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
1:55 PM (5 hours ago) 1:55 PM
to FMorschel, Keerti Parthasarathy, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DAS] Fixes primary constructor body completion
Fixes: https://github.com/dart-lang/sdk/issues/63950
Change-Id: I1de0af89174065d5c24d4dd2d8009a58bdb1be8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/531180
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: FMorschel <g...@fmorschel.dev>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
- M pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
- M pkg/analysis_server/test/services/completion/dart/location/field_declaration_test.dart
- M pkg/analysis_server/test/services/completion/dart/location/primary_constructor_declaration_test.dart
Change size: M
Delta: 4 files changed, 82 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Keerti Parthasarathy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages