[M] Change in dart/sdk[main]: analyzer: Detect and report usage of redirected-constructor parameters
0 views
Skip to first unread message
Paul Berry (Gerrit)
Oct 20, 2025, 4:39:50 PM (21 hours ago) Oct 20
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Oct 20, 2025, 4:41:32 PM (21 hours ago) Oct 20
to Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 20, 2025, 5:13:56 PM (20 hours ago) Oct 20
to Samuel Rawlins, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
analyzer: Detect and report usage of redirected-constructor parameters
The redirected constructor of a redirecting factory constructor may
have @Deprecated or @experimental parameters. To detect these, we must
examine each parameter of a constructor (after noting its own
annotations via `pushElement`), and then look at the corresponding
parameters of the redirecting constructor.
Change-Id: I0368f885c53495d8a50d5e522199ce48bde1b694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455661
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Files:
- M pkg/analyzer/lib/src/error/best_practices_verifier.dart
- M pkg/analyzer/lib/src/error/element_usage_detector.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
Change size: M
Delta: 3 files changed, 156 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages