[M] Change in dart/sdk[main]: [DAS Plugins] Fixes diagnostic messages not showing for plugins

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Jan 9, 2026, 9:17:58 AM (2 days ago) Jan 9
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS Plugins] Fixes diagnostic messages not showing for plugins
Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7

Change information

Files:
  • M pkg/analysis_server/lib/src/protocol_server.dart
  • M pkg/analysis_server_plugin/lib/src/plugin_server.dart
  • A pkg/analysis_server_plugin/lib/src/utilities/diagnostic_messages.dart
  • M pkg/analysis_server_plugin/test/src/lint_rules.dart
  • M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
Change size: M
Delta: 5 files changed, 193 insertions(+), 43 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
Gerrit-Change-Number: 471840
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Jan 9, 2026, 9:20:37 AM (2 days ago) Jan 9
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel added 1 comment

File pkg/analysis_server_plugin/test/src/lint_rules.dart
Line 162, Patchset 1 (Latest):// See https://github.com/dart-lang/sdk/issues/61949
Felipe Morschel . resolved

I intend on fixing this one next, but I'll question some things at the issue first.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
Gerrit-Change-Number: 471840
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 14:20:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Jan 9, 2026, 10:37:21 AM (2 days ago) Jan 9
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Great fix, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Felipe Morschel
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
Gerrit-Change-Number: 471840
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:37:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jan 9, 2026, 10:43:14 AM (2 days ago) Jan 9
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Brian Wilkerson voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
    Gerrit-Change-Number: 471840
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 15:43:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Felipe Morschel (Gerrit)

    unread,
    Jan 9, 2026, 11:16:27 AM (2 days ago) Jan 9
    to Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Samuel Rawlins

    Felipe Morschel voted and added 1 comment

    Votes added by Felipe Morschel

    Auto-Submit+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1:
    Felipe Morschel . resolved

    Fixed a broken test that needed a new mock. Thanks for the bots!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Samuel Rawlins
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
    Gerrit-Change-Number: 471840
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 16:16:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    Jan 9, 2026, 1:52:12 PM (2 days ago) Jan 9
    to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Felipe Morschel and Samuel Rawlins

    Brian Wilkerson voted

    Code-Review+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Morschel
    • Samuel Rawlins
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
    Gerrit-Change-Number: 471840
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 18:52:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Jan 9, 2026, 1:54:32 PM (2 days ago) Jan 9
    to Felipe Morschel, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Felipe Morschel

    Samuel Rawlins voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Morschel
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
      Gerrit-Change-Number: 471840
      Gerrit-PatchSet: 2
      Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
      Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
      Gerrit-Comment-Date: Fri, 09 Jan 2026 18:54:30 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Commit Queue (Gerrit)

      unread,
      Jan 9, 2026, 2:21:07 PM (2 days ago) Jan 9
      to Felipe Morschel, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

      Commit Queue submitted the change

      Change information

      Commit message:
      [DAS Plugins] Fixes diagnostic messages not showing for plugins
      Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
      Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
      Reviewed-by: Samuel Rawlins <sraw...@google.com>
      Reviewed-by: Brian Wilkerson <brianwi...@google.com>
      Commit-Queue: Brian Wilkerson <brianwi...@google.com>
      Commit-Queue: Samuel Rawlins <sraw...@google.com>
      Files:
      • M pkg/analysis_server/lib/src/protocol_server.dart
      • M pkg/analysis_server/test/protocol_server_test.dart
      • M pkg/analysis_server_plugin/lib/src/plugin_server.dart
      • A pkg/analysis_server_plugin/lib/src/utilities/diagnostic_messages.dart
      • M pkg/analysis_server_plugin/test/src/lint_rules.dart
      • M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
        Change size: M
        Delta: 6 files changed, 205 insertions(+), 43 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: I21c33c4af5f0e41fc5015c61f0bf7e2a7229a8f7
        Gerrit-Change-Number: 471840
        Gerrit-PatchSet: 3
        Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages