[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.
Alexander Aprelev (Gerrit)
Alexander Aprelev added 1 comment![]( "Open in Gerrit")
Please let me know what you think, thanks!
Related details
- Slava Egorov
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Slava Egorov added 4 comments![]( "Open in Gerrit")
Initial comments.
Please ask @alexm...@google.com for review while I am away for holidays :)
if (dartType is FunctionType) {1. Please update deeply immutable documentation in the repo (e.g. in `runtime/docs` to match the semantics being implemented).
2. Please add tests to cover new functionality - including both negative and positive tests.
class GuardFieldImmutabilityInstr : public GuardFieldInstr {To avoid confusion with speculative field guards I suggest we use either `CheckImmutableValue` or `AssertImmutableValue`.
Also don't make it subclass of `GuardFieldInstr` (which is `NoThrow`) - these checks are not _speculative_ and don't maintain dynamic guarded field state, they throw when value is incorrect. Thus these checks are more similar to implicit `as` casts than guards.
const Context& context = Context::Handle(zone, closure.GetContext());Once we scanned closure - I wonder if we want to update its tag bits so that next time we come to scan the same closure we don't need to do that?
Related details
- Alexander Aprelev
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Alexander Aprelev voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexander Aprelev
| Commit-Queue | +1 |
2 comments
class GuardFieldImmutabilityInstr : public GuardFieldInstr {To avoid confusion with speculative field guards I suggest we use either `CheckImmutableValue` or `AssertImmutableValue`.
Also don't make it subclass of `GuardFieldInstr` (which is `NoThrow`) - these checks are not _speculative_ and don't maintain dynamic guarded field state, they throw when value is incorrect. Thus these checks are more similar to implicit `as` casts than guards.
Done
const Context& context = Context::Handle(zone, closure.GetContext());Once we scanned closure - I wonder if we want to update its tag bits so that next time we come to scan the same closure we don't need to do that?
- Slava Egorov
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Alexander Aprelev added 1 comment![]( "Open in Gerrit")
1. Please update deeply immutable documentation in the repo (e.g. in `runtime/docs` to match the semantics being implemented).
2. Please add tests to cover new functionality - including both negative and positive tests.
Done
Related details
- Slava Egorov
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |