[L] Change in dart/sdk[main]: [cfe] Support nested prefixes

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
7:14 AM (2 hours ago) 7:14 AM
to Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova

Johnni Winther voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chloe Stefantsova
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I661d08e5abf1459b1b7555c5b5dc89f4d4ad6b6e
Gerrit-Change-Number: 452080
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 11:14:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chloe Stefantsova (Gerrit)

unread,
8:16 AM (1 hour ago) 8:16 AM
to Johnni Winther, Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I661d08e5abf1459b1b7555c5b5dc89f4d4ad6b6e
Gerrit-Change-Number: 452080
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 12:16:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
8:20 AM (1 hour ago) 8:20 AM
to Johnni Winther, Chloe Stefantsova, dart-fe-te...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[cfe] Support nested prefixes

This adds support for expanded a prefix scope in a child compilation unit. If a compilation unit declares a prefix and a child compilation unit declares a prefix of the same name, the scope of the latter is nested within the scope of the former.
Change-Id: I661d08e5abf1459b1b7555c5b5dc89f4d4ad6b6e
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Files:
  • M pkg/front_end/lib/src/builder/compilation_unit.dart
  • M pkg/front_end/lib/src/builder/prefix_builder.dart
  • M pkg/front_end/lib/src/source/source_compilation_unit.dart
  • M pkg/front_end/test/generator_to_string_test.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart.strong.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart.strong.modular.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart.strong.outline.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart.strong.transformed.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart.textual_outline.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix.dart.textual_outline_modelled.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart.strong.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart.strong.modular.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart.strong.outline.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart.strong.transformed.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart.textual_outline.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded.dart.textual_outline_modelled.expect
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded_lib1.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded_lib2.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded_lib3.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded_part1.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_expanded_part2.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_lib.dart
  • A pkg/front_end/testcases/enhanced_parts/part_with_prefix_part.dart
Change size: L
Delta: 25 files changed, 553 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Chloe Stefantsova
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I661d08e5abf1459b1b7555c5b5dc89f4d4ad6b6e
Gerrit-Change-Number: 452080
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages