[M] Change in dart/sdk[main]: api_summary: add basic CLI and validation test
Kevin Moore (Gerrit)
Kevin Moore voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- Paul Berry
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Paul Berry voted and added 6 comments![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
6 comments
print(summary);This will cause an extra newline to be output at the end. Change to:
```
stdout.write(summary);
```
} catch (e, stack) {Drop this catch clause. It doesn't add any value; the default "unhandled exception" behavior does basically the same thing.
help: 'The path to the package to summarize.',Add text explaining that the default is to summarize the current directory.
'Could not find "name" in pubspec.yaml at ${pubspecFile.path}',Misleading error message; this could also fire if the pubspec.yaml file _does_ contain a `name` field, but it has the wrong type.
I would change this to a traditional series of if-tests rather than a switch, so that the error message can explain what went wrong.
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS fileTo address the bot failure, you'll need to give this file a larger timeout. You should be able to do so by editing `pkg/pkg.status` and adding this line to the top section:
```
api_summary/test/app_test: Slow, Pass
```
Related details
- Kevin Moore
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Kevin Moore voted and added 6 comments![]( "Open in Gerrit")
Votes added by Kevin Moore
| Auto-Submit | +1 |
| Commit-Queue | +2 |
6 comments
This will cause an extra newline to be output at the end. Change to:
```
stdout.write(summary);
```
Done
Drop this catch clause. It doesn't add any value; the default "unhandled exception" behavior does basically the same thing.
Done
Add text explaining that the default is to summarize the current directory.
Done
'Could not find "name" in pubspec.yaml at ${pubspecFile.path}',Misleading error message; this could also fire if the pubspec.yaml file _does_ contain a `name` field, but it has the wrong type.
I would change this to a traditional series of if-tests rather than a switch, so that the error message can explain what went wrong.
Done
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS fileTo address the bot failure, you'll need to give this file a larger timeout. You should be able to do so by editing `pkg/pkg.status` and adding this line to the top section:
```
api_summary/test/app_test: Slow, Pass
```
- Paul Berry
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Kevin Moore voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Related details
- Paul Berry
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
| Commit-Queue | +2 |
lgtm
- Kevin Moore
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
api_summary: add basic CLI and validation test
- A pkg/api_summary/api_summary.txt
- A pkg/api_summary/bin/api_summary.dart
- M pkg/api_summary/pubspec.yaml
- A pkg/api_summary/test/app_test.dart
- M pkg/pkg.status
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Zhou (Gerrit)
Mark Zhou added 1 comment![]( "Open in Gerrit")
These tests are timing out some of our bots - can y'all check? https://dart-current-results.web.app/?filter=pkg/api_summary/test/app_test&showAll
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Kevin Moore added 2 comments![]( "Open in Gerrit")
These tests are timing out some of our bots - can y'all check? https://dart-current-results.web.app/?filter=pkg/api_summary/test/app_test&showAll
Sorry!
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Paul Berry added 1 comment![]( "Open in Gerrit")
These tests are timing out some of our bots - can y'all check? https://dart-current-results.web.app/?filter=pkg/api_summary/test/app_test&showAll
Oops, it looks like I was wrong about needing to add that line to `pkg/pkg.status`. What we're supposed to do instead to increase the timeout is documented here: https://pub.dev/packages/test#timeouts
@kev...@google.com, would you mind making a CL to fix this?
Related details
- Kevin Moore
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |