Change in dart/sdk[main]: Re-enable the unnecessary

Dart CI (Gerrit)

unread,

Sep 15, 2021, 1:50:31 PM9/15/21

to Samuel Rawlins, rev...@dartlang.org, Brian Wilkerson, Konstantin Shcheglov, commi...@chromium.org

go/dart-cbuild result: SUCCESS

Details: https://goto.google.com/dart-cbuild/find/a7175039c5be7356fa3e4f467da9e756034adc02

View Change

To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.

Samuel Rawlins (Gerrit)

unread,

Sep 16, 2021, 6:35:01 PM9/16/21

to rev...@dartlang.org, Dart CI, Brian Wilkerson, Konstantin Shcheglov, commi...@chromium.org

Attention is currently required from: Konstantin Shcheglov, Brian Wilkerson.

View Change

To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.

Samuel Rawlins (Gerrit)

unread,

Sep 16, 2021, 6:35:05 PM9/16/21

to rev...@dartlang.org, Dart CI, Brian Wilkerson, Konstantin Shcheglov, commi...@chromium.org

Attention is currently required from: Konstantin Shcheglov, Brian Wilkerson.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.

Samuel Rawlins (Gerrit)

unread,

Sep 17, 2021, 11:48:45 AM9/17/21

to rev...@dartlang.org, Dart CI, Brian Wilkerson, Konstantin Shcheglov, commi...@chromium.org

Attention is currently required from: Konstantin Shcheglov, Brian Wilkerson.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.

commit-bot@chromium.org (Gerrit)

unread,

Sep 17, 2021, 12:11:37 PM9/17/21

to Samuel Rawlins, rev...@dartlang.org, Dart CI, Brian Wilkerson, Konstantin Shcheglov

commi...@chromium.org submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals:
  Konstantin Shcheglov: Looks good to me, approved
  Brian Wilkerson: Looks good to me, approved
  Samuel Rawlins: Commit

Re-enable the unnecessary_imports check

Bug: https://github.com/flutter/flutter/issues/82844
Change-Id: Iaf7017578177952b4871e340b057c442be01bfd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200540
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
---
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
M pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
index a0caf52..78e7fc4 100644
--- a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
@@ -284,9 +284,8 @@
       verifier.generateDuplicateShownHiddenNameHints(errorReporter);
       verifier.generateUnusedImportHints(errorReporter);
       verifier.generateUnusedShownNameHints(errorReporter);
-      // TODO(srawlins): Re-enable this check once Flutter engine path is clear.
-      // verifier.generateUnnecessaryImportHints(
-      //     errorReporter, _usedImportedElementsList);
+      verifier.generateUnnecessaryImportHints(
+          errorReporter, _usedImportedElementsList);
     }
 
     // Unused local elements.
diff --git a/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart b/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
index a5c76d1..b6071fc 100644
--- a/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
+++ b/pkg/analyzer/test/src/diagnostics/unnecessary_import_test.dart
@@ -9,8 +9,7 @@
 
 main() {
   defineReflectiveSuite(() {
-    // TODO(srawlins): Re-enable this check once Flutter engine path is clear.
-    // defineReflectiveTests(UnnecessaryImportTest);
+    defineReflectiveTests(UnnecessaryImportTest);
   });
 }

To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.

Dart CI (Gerrit)

unread,

Sep 17, 2021, 12:40:55 PM9/17/21

to commi...@chromium.org, Samuel Rawlins, rev...@dartlang.org, Brian Wilkerson, Konstantin Shcheglov

go/dart-cbuild result: SUCCESS

Details: https://goto.google.com/dart-cbuild/find/cf143bb60b60055b2f2b40e4b59e35b9e3e4b028

View Change

To view, visit change 200540. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

Change in dart/sdk[main]: Re-enable the unnecessary_imports check

Dart CI (Gerrit)

Samuel Rawlins (Gerrit)

Samuel Rawlins (Gerrit)

Samuel Rawlins (Gerrit)

commit-bot@chromium.org (Gerrit)

Dart CI (Gerrit)