[S] Change in dart/sdk[main]: [vm] Fix race between DartEntry::InvokeFunction and background compil...
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Dec 10, 2025, 7:09:54 PM12/10/25
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 10, 2025, 8:18:50 PM12/10/25
to Ryan Macnak, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Markov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Dec 10, 2025, 10:23:41 PM12/10/25
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 10, 2025, 10:23:54 PM12/10/25
to Ryan Macnak, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Fix race between DartEntry::InvokeFunction and background compiler / other isolates.
Before:
code := function.CurrentCode()
safepoint transition VM->Generated (might yield to background compiler's safepoint operation)
InvokeEntryStub(code)
After:
safepoint transition VM->Generated (might yield to background compiler's safepoint operation)
code := function.CurrentCode()
InvokeEntryStub(code)
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/60492
Bug: https://github.com/dart-lang/sdk/issues/62169
Change-Id: I9f0ac207361ed38101ca3fae10766894c4c5e47c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467480
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
- M runtime/vm/dart_entry.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages