[S] Change in dart/sdk[main]: Reland "[build] Make `build_analyze_snapshot` consistent between the ...
Ryan Macnak (Gerrit)
Attention is currently required from: Daco Harkes.
To view, visit change 281460. To unsubscribe, or for help writing mail filters, visit settings.
Ryan Macnak (Gerrit)
Attention is currently required from: Daco Harkes.
Ryan Macnak would like Daco Harkes to review this change.
Reland "[build] Make `build_analyze_snapshot` consistent between the host and target toolchains."
Also create this target for Fuchsia, which like Linux and Android uses ELF.
Bug: https://github.com/dart-lang/sdk/issues/51242
Change-Id: I8e991d361b5defaa52b62a78d515a7639a6dfba0
---
M runtime/runtime_args.gni
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/runtime/runtime_args.gni b/runtime/runtime_args.gni
index 0c4f1ea..ba761a2 100644
--- a/runtime/runtime_args.gni
+++ b/runtime/runtime_args.gni
@@ -89,9 +89,10 @@
# which is already linked in the VM.
create_kernel_service_snapshot = dart_target_arch == "x64"
- # The analyze_snapshot tool is only supported on 64 bit AOT builds running
- # under linux and android platforms
+ # The analyze_snapshot tool is only supported on 64 bit AOT builds that use
+ # ELF.
build_analyze_snapshot =
- (is_linux || is_android) &&
+ (target_os == "linux" || target_os == "android" ||
+ target_os == "fuchsia") &&
(dart_target_arch == "x64" || dart_target_arch == "arm64")
}
To view, visit change 281460. To unsubscribe, or for help writing mail filters, visit settings.
Daco Harkes (Gerrit)
Attention is currently required from: Ryan Macnak.
Patch set 1:Code-Review +1
1 comment:
Patchset:
Thanks Ryan!
To view, visit change 281460. To unsubscribe, or for help writing mail filters, visit settings.
CBuild (Gerrit)
Attention is currently required from: Ryan Macnak.
go/dart-cbuild result: FAILURE (NO REGRESSIONS DETECTED)
Details: https://goto.google.com/dart-cbuild/find/c0cee053f203b2a513d7ff9d689f6fa55067ade3
Ryan Macnak (Gerrit)
Attention is currently required from: Ryan Macnak.
Patch set 1:Commit-Queue +2
Commit Queue (Gerrit)
Commit Queue submitted this change.
Reland "[build] Make `build_analyze_snapshot` consistent between the host and target toolchains."
Also create this target for Fuchsia, which like Linux and Android uses ELF.
Bug: https://github.com/dart-lang/sdk/issues/51242
Change-Id: I8e991d361b5defaa52b62a78d515a7639a6dfba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281460
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
---
M runtime/runtime_args.gni
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/runtime/runtime_args.gni b/runtime/runtime_args.gni
index 0c4f1ea..ba761a2 100644
--- a/runtime/runtime_args.gni
+++ b/runtime/runtime_args.gni
@@ -89,9 +89,10 @@
# which is already linked in the VM.
create_kernel_service_snapshot = dart_target_arch == "x64"
- # The analyze_snapshot tool is only supported on 64 bit AOT builds running
- # under linux and android platforms
+ # The analyze_snapshot tool is only supported on 64 bit AOT builds that use
+ # ELF.
build_analyze_snapshot =
- (is_linux || is_android) &&
+ (target_os == "linux" || target_os == "android" ||
+ target_os == "fuchsia") &&
(dart_target_arch == "x64" || dart_target_arch == "arm64")
}
To view, visit change 281460. To unsubscribe, or for help writing mail filters, visit settings.
CBuild (Gerrit)
go/dart-cbuild result: SUCCESS
Details: https://goto.google.com/dart-cbuild/find/e8b6c8a44f8f5e2b7a4f48206e82be438a0720c2