[XS] Change in dart/sdk[main]: DDS: Use named parameters in a few missed places
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
9:57 AM (11 hours ago) 9:57 AM
to Brian Quinlan, Commit Queue, rev...@dartlang.org
Attention needed from Brian Quinlan
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brian Quinlan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Quinlan (Gerrit)
2:10 PM (6 hours ago) 2:10 PM
to Samuel Rawlins, Commit Queue, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Quinlan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
2:11 PM (6 hours ago) 2:11 PM
to Brian Quinlan, Commit Queue, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
2:11 PM (6 hours ago) 2:11 PM
to Samuel Rawlins, Brian Quinlan, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DDS: Use named parameters in a few missed places
Work towards https://github.com/dart-lang/sdk/issues/58729.
The lint rule will suggest using a super-parameter for a named
parameter even if the positional parameters cannot be super-parameters.
Change-Id: I5e5fcfb5af9c8e0eee912478d1a83f547d9ff449
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491560
Reviewed-by: Brian Quinlan <bqui...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/dds/lib/src/dap/adapters/dart.dart
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Quinlan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages