[M] Change in dart/sdk[main]: [lints] address diagnostics related to strict_top_level_inference
0 views
Skip to first unread message
Devon Carew (Gerrit)
Mar 12, 2025, 1:08:04 PM3/12/25
to Nate Bosch, Ben Konyi, Nate Biggs, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Ben Konyi, Nate Biggs and Nate Bosch
Devon Carew added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Devon Carew . resolved
Address diagnostics from the new 'strict_top_level_inference' lint.
Most of these are mechanical changes. There were a few packages that had hundreds or thousands of violations due to some test code patterns. For these, I addressed the non-test diagnostics and then ignored the lint in the analysis_options config w/ a comment about the remaining issues.
This touches a bit of everything, but the bulk of the changes are in infra, web, and developer sevices code.
Related details
Attention is currently required from:
- Ben Konyi
- Nate Biggs
- Nate Bosch
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Bosch (Gerrit)
Mar 12, 2025, 10:36:34 PM3/12/25
to Devon Carew, Ben Konyi, Nate Biggs, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Ben Konyi, Devon Carew and Nate Biggs
Nate Bosch voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nate Bosch
| Code-Review | +1 |
1 comment
File pkg/analyzer_plugin/test/integration/support/integration_tests.dart
Line 41, Patchset 2 (Latest):
void outOfTestExpect(dynamic actual, Matcher matcher,Nate Bosch . unresolved
[optional] Consider making arguments `Object?` in place of `dynamic` and cast to `dynamic` if we need dynamic behavior. It looks like most of these are effectively treated as `Object?` anyway so we might not end up needing any casts.
Related details
Attention is currently required from:
- Ben Konyi
- Devon Carew
- Nate Biggs
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Mar 13, 2025, 1:38:20 PM3/13/25
to Devon Carew, Nate Bosch, Nate Biggs, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Devon Carew and Nate Biggs
Ben Konyi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Devon Carew
- Nate Biggs
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Carew (Gerrit)
Mar 13, 2025, 3:32:29 PM3/13/25
to Ben Konyi, Nate Bosch, Nate Biggs, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs and Nate Bosch
Devon Carew added 1 comment![]( "Open in Gerrit")
File pkg/analyzer_plugin/test/integration/support/integration_tests.dart
Line 41, Patchset 2 (Latest):
void outOfTestExpect(dynamic actual, Matcher matcher,Nate Bosch . unresolved
[optional] Consider making arguments `Object?` in place of `dynamic` and cast to `dynamic` if we need dynamic behavior. It looks like most of these are effectively treated as `Object?` anyway so we might not end up needing any casts.
Devon Carew
For this CL, I mostly tried to use `Object?`, but did use `dynamic` in places where related call sites were already using dynamic.
I'll take a pass through and see if any of the dynamics should change to Object?.
Related details
Attention is currently required from:
- Nate Biggs
- Nate Bosch
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Carew (Gerrit)
Mar 13, 2025, 4:32:50 PM3/13/25
to Ben Konyi, Nate Bosch, Nate Biggs, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs and Nate Bosch
Devon Carew voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Nate Biggs
- Nate Bosch
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Mar 13, 2025, 4:58:00 PM3/13/25
to Devon Carew, Ben Konyi, Nate Bosch, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Devon Carew and Nate Bosch
Nate Biggs voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Devon Carew
- Nate Bosch
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Carew (Gerrit)
Mar 13, 2025, 7:58:31 PM3/13/25
to Nate Biggs, Ben Konyi, Nate Bosch, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Devon Carew voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 14, 2025, 2:13:32 PM3/14/25
to Devon Carew, Nate Biggs, Ben Konyi, Nate Bosch, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Devon Carew
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Samuel Rawlins . resolved
Thanks for doing this, Devon. I think this is a big win 😄
Related details
Attention is currently required from:
- Devon Carew
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devon Carew (Gerrit)
Mar 17, 2025, 10:45:26 AM3/17/25
to Samuel Rawlins, Nate Biggs, Ben Konyi, Nate Bosch, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Devon Carew voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 17, 2025, 11:28:01 AM3/17/25
to Devon Carew, Samuel Rawlins, Nate Biggs, Ben Konyi, Nate Bosch, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[lints] address diagnostics related to strict_top_level_inference
Change-Id: I228058202855900f0adba73c1ab04d35180a6e5d
Tested: this is an analyzer diagnostic only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414900
Reviewed-by: Nate Bosch <nbo...@google.com>
Commit-Queue: Devon Carew <devon...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Reviewed-by: Ben Konyi <bko...@google.com>
Files:
- M DEPS
- M pkg/analysis_server/tool/benchmark_tools/language_server_benchmark.dart
- M pkg/analyzer/analysis_options.yaml
- M pkg/analyzer_plugin/test/integration/support/integration_tests.dart
- M pkg/build_integration/test/file_system/multi_root_test.dart
- M pkg/build_integration/test/file_system/single_root_test.dart
- M pkg/dart2bytecode/analysis_options.yaml
- M pkg/dart2bytecode/bin/dump_bytecode.dart
- M pkg/dart2bytecode/lib/bytecode_generator.dart
- M pkg/dart2bytecode/lib/disassembler.dart
- M pkg/dart2bytecode/lib/local_vars.dart
- M pkg/dart2js_info/lib/src/table.dart
- M pkg/dart2js_info/lib/src/util.dart
- M pkg/dart2js_tools/lib/src/dart2js_mapping.dart
- M pkg/dart2js_tools/lib/src/util.dart
- M pkg/dart2wasm/lib/option.dart
- M pkg/dds/analysis_options.yaml
- M pkg/dds/lib/src/dap/adapters/dart.dart
- M pkg/dds/lib/src/dap_handler.dart
- M pkg/dev_compiler/analysis_options.yaml
- M pkg/dev_compiler/lib/src/js_ast/nodes.dart
- M pkg/dev_compiler/lib/src/js_ast/template.dart
- M pkg/dynamic_modules/bin/dynamic_module_runner.dart
- M pkg/dynamic_modules/test/data/apply_mixin/main.dart
- M pkg/dynamic_modules/test/data/closure_invocation/main.dart
- M pkg/dynamic_modules/test/data/core_api/main.dart
- M pkg/dynamic_modules/test/data/duplicate_library/main.dart
- M pkg/dynamic_modules/test/data/dyn_module_type_checks/main.dart
- M pkg/dynamic_modules/test/data/extend_class/main.dart
- M pkg/dynamic_modules/test/data/extend_class2/main.dart
- M pkg/dynamic_modules/test/data/extend_class_dyn_only/main.dart
- M pkg/dynamic_modules/test/data/extend_class_generics/main.dart
- M pkg/dynamic_modules/test/data/implement_interface/main.dart
- M pkg/dynamic_modules/test/data/implicitly_extendable/main.dart
- M pkg/dynamic_modules/test/data/indirect_expose/main.dart
- M pkg/dynamic_modules/test/data/load_twice/main.dart
- M pkg/dynamic_modules/test/data/load_unmodifiable_view/main.dart
- M pkg/dynamic_modules/test/data/multiple_classes/main.dart
- M pkg/dynamic_modules/test/data/override_extra_params/main.dart
- M pkg/dynamic_modules/test/data/reshape_selectors/main.dart
- M pkg/dynamic_modules/test/data/same_record_shape/main.dart
- M pkg/dynamic_modules/test/data/shared_const/main.dart
- M pkg/dynamic_modules/test/data/tearoff_no_concrete_impl/main.dart
- M pkg/dynamic_modules/test/data/top_level/main.dart
- M pkg/expect/test/identical_distinct_test.dart
- M pkg/heap_snapshot/test/int_set_benchmark.dart
- M pkg/heap_snapshot/test/int_set_test.dart
- M pkg/js_ast/lib/src/template.dart
- M pkg/modular_test/lib/src/loader.dart
- M pkg/modular_test/test/find_sdk_root1_test.dart
- M pkg/modular_test/test/io_pipeline_test.dart
- M pkg/modular_test/test/loader/loader_test.dart
- M pkg/modular_test/test/memory_pipeline_test.dart
- M pkg/modular_test/test/pipeline_common.dart
- M pkg/modular_test/test/specification_parser_test.dart
- M pkg/modular_test/test/src/find_sdk_root2_test.dart
- M pkg/modular_test/test/validate_pipeline_test.dart
- M pkg/modular_test/test/validate_suite_test.dart
- M pkg/status_file/bin/lint.dart
- M pkg/status_file/bin/remove_non_essential_entries.dart
- M pkg/status_file/lib/src/disjunctive.dart
- M pkg/status_file/test/linter_test.dart
- M pkg/status_file/test/normalize_test.dart
- M pkg/status_file/test/status_expression_dnf_test.dart
- M pkg/status_file/test/status_expression_test.dart
- M pkg/test_runner/lib/src/browser_controller.dart
- M pkg/test_runner/lib/src/testing_servers.dart
- M pkg/test_runner/test/dependency_graph_test.dart
- M pkg/test_runner/test/experiment_test.dart
- M pkg/test_runner/test/skipping_dart2js_compilations_helper.dart
- M pkg/test_runner/test/test_runner_test.dart
- M pkg/testing/lib/src/chain.dart
- M pkg/testing/lib/src/log.dart
- M pkg/vm/analysis_options.yaml
- M pkg/vm/bin/list_libraries.dart
- M pkg/vm_service/analysis_options.yaml
- M third_party/pkg/dap/lib/src/protocol_special.dart
- M third_party/pkg/language_server_protocol/lib/protocol_special.dart
Change size: M
Delta: 78 files changed, 134 insertions(+), 104 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Bosch, +1 by Nate Biggs, +1 by Ben Konyi, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages