[M] Change in dart/sdk[main]: [dart:io, fuchsia] Fix use-after-free when closing a server socket on...
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Jun 22, 2026, 9:14:29 PM (2 days ago) Jun 22
to Slava Egorov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Jun 23, 2026, 3:39:53 AM (22 hours ago) Jun 23
to Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jun 23, 2026, 5:52:19 PM (8 hours ago) Jun 23
to Slava Egorov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 5:52:36 PM (8 hours ago) Jun 23
to Ryan Macnak, Slava Egorov, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: BUILD.gn
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: tests/standalone/io/regress_b_524683625_test.dart
Insertions: 3, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[dart:io, fuchsia] Fix use-after-free when closing a server socket on the event handler's thread races with accept/read/write on the Dart thread.
- Add ASAN and UBSAN builder configurations.
- Fix mismatch in build directory computation between build.py and test.py.
- Manually add the sanitizer runtime libraries to the test package.
- Fix memory leak in failing to load the profiler symbols.
- Fix memory leak in CPU feature detection.
- Remove any pending packets refering to the socket's DescriptorInfo before deleting it.
TEST=ci (though ASAN doesn't detect the issue without extra sleeps)
Bug: b/524683625
Change-Id: Icddf9a34889e2b96cdf6d6db2ac142abdb052bd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/516140
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
- M BUILD.gn
- M runtime/bin/eventhandler_fuchsia.cc
- M runtime/bin/exe_utils.cc
- M runtime/vm/cpuinfo_fuchsia.cc
- A tests/standalone/io/regress_b_524683625_test.dart
- M tools/bots/test_matrix.json
- M tools/utils.py
Change size: M
Delta: 7 files changed, 207 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages