[XS] Change in dart/sdk[main]: Convert an addReplacement() to addSimpleReplacement().

0 views
Skip to first unread message

Bob Nystrom (Gerrit)

unread,
Jan 20, 2026, 8:52:54 PM (2 days ago) Jan 20
to Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Bob Nystrom voted and added 1 comment

Votes added by Bob Nystrom

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Bob Nystrom . resolved

Sorry for the tiny CL. :)

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I32f24d1e69145d52e69fe4edbf64a08b28ea5ea8
Gerrit-Change-Number: 474493
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 01:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Jan 20, 2026, 9:03:19 PM (2 days ago) Jan 20
to Bob Nystrom, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Bob Nystrom and Brian Wilkerson

Samuel Rawlins voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bob Nystrom
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I32f24d1e69145d52e69fe4edbf64a08b28ea5ea8
Gerrit-Change-Number: 474493
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Bob Nystrom <rnys...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 02:03:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Jan 20, 2026, 9:15:51 PM (2 days ago) Jan 20
to Bob Nystrom, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Convert an addReplacement() to addSimpleReplacement().
Change-Id: I32f24d1e69145d52e69fe4edbf64a08b28ea5ea8
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Bob Nystrom <rnys...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>
Files:
  • M pkg/analysis_server/lib/src/services/correction/dart/convert_field_formal_to_normal.dart
Change size: XS
Delta: 1 file changed, 1 insertion(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Samuel Rawlins
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I32f24d1e69145d52e69fe4edbf64a08b28ea5ea8
Gerrit-Change-Number: 474493
Gerrit-PatchSet: 2
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
open
diffy
satisfied_requirement

Brian Wilkerson (Gerrit)

unread,
Jan 21, 2026, 9:59:48 AM (14 hours ago) Jan 21
to Bob Nystrom, Commit Queue, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I32f24d1e69145d52e69fe4edbf64a08b28ea5ea8
Gerrit-Change-Number: 474493
Gerrit-PatchSet: 2
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 14:59:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages