[M] Change in dart/sdk[main]: DAS insights: Linkify more files to their contents

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Mar 13, 2026, 4:55:33 PMMar 13
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7c505b006872e70884bf4c59a34e0625c7663a6c
Gerrit-Change-Number: 487946
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 20:55:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Mar 13, 2026, 9:37:15 PMMar 13
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Samuel Rawlins voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7c505b006872e70884bf4c59a34e0625c7663a6c
Gerrit-Change-Number: 487946
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Sat, 14 Mar 2026 01:37:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 13, 2026, 9:37:33 PMMar 13
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
DAS insights: Linkify more files to their contents

The main piece to this CL is to add more links in the diagnostics pages.
We add links to pubspec files in a context, and to the generated package
config files for plugins.

I also rename `writeOption` to `formatOption` as it doesn't actually
write (it just returns a String).

I also fix a few small UX issues:

* Contents page titles should break on slashes, so I just updated all
page titles to break on slashes.
* A small bug where a context with zero library cycles of size > 1
display the text "They contain" and then no more text.
Change-Id: I7c505b006872e70884bf4c59a34e0625c7663a6c
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
  • M pkg/analysis_server/lib/src/status/diagnostics.dart
  • M pkg/analysis_server/lib/src/status/pages/communications_page.dart
  • M pkg/analysis_server/lib/src/status/pages/contexts_page.dart
  • M pkg/analysis_server/lib/src/status/pages/exceptions_page.dart
  • M pkg/analysis_server/lib/src/status/pages/memory_and_cpu_page.dart
  • M pkg/analysis_server/lib/src/status/pages/message_scheduler_page.dart
  • M pkg/analysis_server/lib/src/status/pages/plugins_page.dart
  • M pkg/analysis_server/lib/src/status/pages/status_page.dart
Change size: M
Delta: 8 files changed, 60 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7c505b006872e70884bf4c59a34e0625c7663a6c
Gerrit-Change-Number: 487946
Gerrit-PatchSet: 3
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages