[S] Change in dart/sdk[main]: [pkg/vm_service] Handle lack of optimized out variables in interpreter.
0 views
Skip to first unread message
Tess Strickland (Gerrit)
Nov 25, 2025, 8:19:40 AM (7 days ago) Nov 25
to Alexander Markov, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tess Strickland . resolved
A slightly different approach here, since the test is testing something that isn't actually required for the interpreter, so I'm adjusting the test instead to just test the variable evaluation as normal when interpreted.
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 1, 2025, 11:48:08 AM (yesterday) Dec 1
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov added 1 comment![]( "Open in Gerrit")
File pkg/vm_service/test/evaluate_optimized_out_variable_test.dart
Line 52, Patchset 1 (Latest):
final isOptimizedOut = !isInterpreted;Alexander Markov . unresolved
The detection of the interpreted mode and different test expectations look fragile.
I think the ability to correctly evaluate `data.length` is (also) a correct behavior, so the test should just accept both behaviors without checking if interpreter is used or not.
Related details
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
7:30 AM (8 hours ago) 7:30 AM
to Alexander Markov, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tess Strickland
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tess Strickland . resolved
Thanks, Alex! Have changed the test to just allow either behavior, PTAL.
File pkg/vm_service/test/evaluate_optimized_out_variable_test.dart
The detection of the interpreted mode and different test expectations look fragile.
I think the ability to correctly evaluate `data.length` is (also) a correct behavior, so the test should just accept both behaviors without checking if interpreter is used or not.
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
9:26 AM (6 hours ago) 9:26 AM
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
9:52 AM (6 hours ago) 9:52 AM
to Alexander Markov, Commit Queue, rev...@dartlang.org
Tess Strickland voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
9:53 AM (6 hours ago) 9:53 AM
to Tess Strickland, Alexander Markov, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[pkg/vm_service] Handle lack of optimized out variables in interpreter.
Test the evaluation of the variable as normal when interpreted, and
expect the appropriate RPCError when not interpreted.
TEST=pkg/vm_service/test/evaluate_optimized_out_variable_test
Cq-Include-Trybots: luci.dart.try:vm-linux-release-x64-try,vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try
Change-Id: I964b75fcfbd789aa7ee5b02c325d028a1a9394f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464441
Reviewed-by: Alexander Markov <alexm...@google.com>
Commit-Queue: Tess Strickland <sstr...@google.com>
Files:
- M pkg/vm_service/test/evaluate_optimized_out_variable_test.dart
Change size: XS
Delta: 1 file changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages