[M] Change in dart/sdk[main]: [DAS] Adds `Remove async` fix for `async_return_with_no_await`

0 views
Skip to first unread message

FMorschel (Gerrit)

unread,
Jun 5, 2026, 12:24:41 PMJun 5
to dart-analys...@google.com, rev...@dartlang.org

FMorschel has uploaded the change for review

Commit message

[DAS] Adds `Remove async` fix for `async_return_with_no_await`
Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66

Change information

Files:
  • M pkg/analysis_server/lib/src/services/correction/dart/remove_async.dart
  • M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
  • M pkg/analysis_server/test/src/services/correction/fix/remove_async_test.dart
Change size: M
Delta: 3 files changed, 96 insertions(+), 14 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
Gerrit-Change-Number: 509660
Gerrit-PatchSet: 1
Gerrit-Owner: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jun 5, 2026, 12:40:16 PMJun 5
to FMorschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from FMorschel and Samuel Rawlins

Brian Wilkerson added 1 comment

File pkg/analysis_server/lib/src/services/correction/fix_internal.dart
Line 289, Patchset 1 (Latest): diag.asyncReturnWithNoAwait: [AddAwait.return_, RemoveAsync.unawaited],
Brian Wilkerson . unresolved

I don't understand why this would be a valid fix for this diagnostic. (Consider replying to my question on the issue so that it's easier for others to find it.)

Open in Gerrit

Related details

Attention is currently required from:
  • FMorschel
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
Gerrit-Change-Number: 509660
Gerrit-PatchSet: 1
Gerrit-Owner: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: FMorschel <g...@fmorschel.dev>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 05 Jun 2026 16:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

FMorschel (Gerrit)

unread,
Jun 5, 2026, 12:49:11 PMJun 5
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

FMorschel added 1 comment

File pkg/analysis_server/lib/src/services/correction/fix_internal.dart
Line 289, Patchset 1 (Latest): diag.asyncReturnWithNoAwait: [AddAwait.return_, RemoveAsync.unawaited],
Brian Wilkerson . unresolved

I don't understand why this would be a valid fix for this diagnostic. (Consider replying to my question on the issue so that it's easier for others to find it.)

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
Gerrit-Change-Number: 509660
Gerrit-PatchSet: 1
Gerrit-Owner: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 05 Jun 2026 16:49:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jul 9, 2026, 3:29:51 PMJul 9
to FMorschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from FMorschel and Samuel Rawlins

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review+1
Commit-Queue+1

1 comment

File pkg/analysis_server/lib/src/services/correction/fix_internal.dart
Line 289, Patchset 1 (Latest): diag.asyncReturnWithNoAwait: [AddAwait.return_, RemoveAsync.unawaited],
Brian Wilkerson . resolved

I don't understand why this would be a valid fix for this diagnostic. (Consider replying to my question on the issue so that it's easier for others to find it.)

FMorschel

https://github.com/dart-lang/sdk/issues/62555#issuecomment-4633644411

Brian Wilkerson

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • FMorschel
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
Gerrit-Change-Number: 509660
Gerrit-PatchSet: 1
Gerrit-Owner: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: FMorschel <g...@fmorschel.dev>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 19:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
Comment-In-Reply-To: FMorschel <g...@fmorschel.dev>
satisfied_requirement
unsatisfied_requirement
open
diffy

FMorschel (Gerrit)

unread,
Jul 10, 2026, 1:10:59 PMJul 10
to dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
FMorschel . resolved

Friendly ping @sraw...@google.com. I'm working on so many things side by side that I think this one got lost hahaha.

Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
Gerrit-Change-Number: 509660
Gerrit-PatchSet: 2
Gerrit-Owner: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 17:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
12:21 PM (7 hours ago) 12:21 PM
to FMorschel, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from FMorschel

Keerti Parthasarathy voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • FMorschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
    Gerrit-Change-Number: 509660
    Gerrit-PatchSet: 2
    Gerrit-Owner: FMorschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Attention: FMorschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 16:21:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    FMorschel (Gerrit)

    unread,
    12:57 PM (6 hours ago) 12:57 PM
    to Keerti Parthasarathy, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Keerti Parthasarathy

    FMorschel voted and added 1 comment

    Votes added by FMorschel

    Auto-Submit+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2:
    FMorschel . resolved

    Thanks for the bots! Some recent changes renamed the `experiments` but I actually didn't need them.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Keerti Parthasarathy
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
    Gerrit-Change-Number: 509660
    Gerrit-PatchSet: 2
    Gerrit-Owner: FMorschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 16:57:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    2:21 PM (5 hours ago) 2:21 PM
    to FMorschel, Brian Wilkerson, Keerti Parthasarathy, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from FMorschel and Keerti Parthasarathy

    Brian Wilkerson voted

    Code-Review+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • FMorschel
    • Keerti Parthasarathy
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie684441eafb18b18d35ddb907ab3d12769692b66
    Gerrit-Change-Number: 509660
    Gerrit-PatchSet: 3
    Gerrit-Owner: FMorschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: FMorschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Attention: FMorschel <g...@fmorschel.dev>
    Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 18:21:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages