[XS] Change in dart/sdk[main]: [modular_aot] Serialization of UndefinedConstant in module snapshots

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Jun 2, 2026, 3:53:25 PM (yesterday) Jun 2
to Alexander Markov, Slava Egorov, Nate Biggs, Alexander Aprelev, Tess Strickland, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I94509fe61830174eecaec6ccfaeb13c6d20c4c27
Gerrit-Change-Number: 508707
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Tue, 02 Jun 2026 19:53:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
2:03 PM (3 hours ago) 2:03 PM
to Alexander Markov, Nate Biggs, Alexander Aprelev, Tess Strickland, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I94509fe61830174eecaec6ccfaeb13c6d20c4c27
Gerrit-Change-Number: 508707
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 18:02:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
2:32 PM (3 hours ago) 2:32 PM
to Alexander Markov, Slava Egorov, Nate Biggs, Alexander Aprelev, Tess Strickland, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org

Alexander Markov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I94509fe61830174eecaec6ccfaeb13c6d20c4c27
    Gerrit-Change-Number: 508707
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Slava Egorov <veg...@google.com>
    Gerrit-CC: Alexander Aprelev <a...@google.com>
    Gerrit-CC: Nate Biggs <nate...@google.com>
    Gerrit-CC: Nicholas Shahan <nsh...@google.com>
    Gerrit-CC: Stephen Adams <s...@google.com>
    Gerrit-CC: Tess Strickland <sstr...@google.com>
    Gerrit-Comment-Date: Wed, 03 Jun 2026 18:32:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    2:32 PM (3 hours ago) 2:32 PM
    to Alexander Markov, Slava Egorov, Nate Biggs, Alexander Aprelev, Tess Strickland, Nicholas Shahan, Stephen Adams, rev...@dartlang.org, vm-...@dartlang.org

    dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [modular_aot] Serialization of UndefinedConstant in module snapshots

    TEST=ci
    Issue: https://github.com/dart-lang/sdk/issues/61635
    Change-Id: I94509fe61830174eecaec6ccfaeb13c6d20c4c27
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508707
    Reviewed-by: Slava Egorov <veg...@google.com>
    Commit-Queue: Alexander Markov <alexm...@google.com>
    Files:
    • M pkg/native_compiler/lib/snapshot/snapshot.dart
    • M runtime/vm/module_snapshot.cc
    Change size: XS
    Delta: 2 files changed, 2 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Slava Egorov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I94509fe61830174eecaec6ccfaeb13c6d20c4c27
    Gerrit-Change-Number: 508707
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Slava Egorov <veg...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages