[M] Change in dart/sdk[main]: [DAS] Fixes "Create missing overrides" for unary operators
0 views
Skip to first unread message
Felipe Morschel (Gerrit)
Jul 30, 2025, 7:19:29 AMJul 30
to dart-analys...@google.com, rev...@dartlang.org
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[DAS] Fixes "Create missing overrides" for unary operators
Change-Id: I8f50bc0cec05734ddb182256345ccb1462c35636
Change information
Files:
- M pkg/analysis_server/test/src/services/correction/fix/create_missing_overrides_test.dart
- M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
Change size: M
Delta: 2 files changed, 102 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Sep 22, 2025, 2:18:46 PM (7 days ago) Sep 22
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Felipe Morschel . unresolved
Friendly ping @sraw...@google.com and @brianwi...@google.com.
Can I get reviews here please? Thanks a lot!
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Sep 22, 2025, 7:13:54 PM (7 days ago) Sep 22
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Sep 22, 2025, 7:49:06 PM (7 days ago) Sep 22
to Commit Queue, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
Felipe Morschel . unresolved
Friendly ping @sraw...@google.com and @brianwi...@google.com.
Can I get reviews here please? Thanks a lot!
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Sep 22, 2025, 8:58:16 PM (7 days ago) Sep 22
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Brian Wilkerson
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Sep 26, 2025, 1:51:43 PM (3 days ago) Sep 26
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Sep 26, 2025, 2:19:02 PM (3 days ago) Sep 26
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DAS] Fixes "Create missing overrides" for unary operators
Change-Id: I8f50bc0cec05734ddb182256345ccb1462c35636
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442800
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/test/lsp/completion_dart_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_missing_overrides_test.dart
- M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
Change size: M
Delta: 3 files changed, 102 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
8:39 AM (13 hours ago) 8:39 AM
to Commit Queue, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Felipe Morschel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Felipe MorschelFriendly ping @sraw...@google.com and @brianwi...@google.com.
Can I get reviews here please? Thanks a lot!
Thanks for the bots run! Fixed the broken test!
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages