[M] Change in dart/sdk[main]: analyzer: Deprecate legacy analyzer plugins
Samuel Rawlins (Gerrit)
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
hasPublishedDocs: falseDo we want to have documentation for this?
I could imagine adding a common fix like "Contact the authors of the plugins you use to determine whether they have a replacement that uses the new plugin support. If so, convert to using the new plugins. If not, let them know how much you appreciate their plugin and encourage them to continue to support it under the new plugin framework."
Related details
- Konstantin Shcheglov
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Code-Review | +1 |
1 comment
if (analyzer.valueAt(AnalysisOptionsFileKeys.plugins) != null) {Maybe simplify to:
```
if (analyzer.getKey(AnalysisOptionsFileKeys.plugins) case var keyNode?) {
reporter.report(
diag.analysisOptionsDeprecatedPlugins.atSourceSpan(keyNode.span),
);
}
```
Related details
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
hasPublishedDocs: falseDo we want to have documentation for this?
I could imagine adding a common fix like "Contact the authors of the plugins you use to determine whether they have a replacement that uses the new plugin support. If so, convert to using the new plugins. If not, let them know how much you appreciate their plugin and encourage them to continue to support it under the new plugin framework."
I like that! Is that something we add after the CL lands? Or we land it now, but leave hasPublishedDocs false until Parker publishes them to the website?
Related details
- Brian Wilkerson
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
hasPublishedDocs: falseSamuel RawlinsDo we want to have documentation for this?
I could imagine adding a common fix like "Contact the authors of the plugins you use to determine whether they have a replacement that uses the new plugin support. If so, convert to using the new plugins. If not, let them know how much you appreciate their plugin and encourage them to continue to support it under the new plugin framework."
I like that! Is that something we add after the CL lands? Or we land it now, but leave hasPublishedDocs false until Parker publishes them to the website?
The docs need to be landed first, with `hasPublishedDocs: false`, then Parker can publish them, then we can mark them as published. All of the CLs need to be cherry picked in order for the docs to be seen by 3.13 users.
Related details
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
hasPublishedDocs: falseSamuel RawlinsDo we want to have documentation for this?
I could imagine adding a common fix like "Contact the authors of the plugins you use to determine whether they have a replacement that uses the new plugin support. If so, convert to using the new plugins. If not, let them know how much you appreciate their plugin and encourage them to continue to support it under the new plugin framework."
Brian WilkersonI like that! Is that something we add after the CL lands? Or we land it now, but leave hasPublishedDocs false until Parker publishes them to the website?
The docs need to be landed first, with `hasPublishedDocs: false`, then Parker can publish them, then we can mark them as published. All of the CLs need to be cherry picked in order for the docs to be seen by 3.13 users.
But it's OK to have Connie look at them after the fact. We can update and re-publish them at any time without needing to cherry-pick them.
Related details
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins added 2 comments![]( "Open in Gerrit")
if (analyzer.valueAt(AnalysisOptionsFileKeys.plugins) != null) {Maybe simplify to:
```
if (analyzer.getKey(AnalysisOptionsFileKeys.plugins) case var keyNode?) {
reporter.report(
diag.analysisOptionsDeprecatedPlugins.atSourceSpan(keyNode.span),
);
}
```
Done
Samuel RawlinsDo we want to have documentation for this?
I could imagine adding a common fix like "Contact the authors of the plugins you use to determine whether they have a replacement that uses the new plugin support. If so, convert to using the new plugins. If not, let them know how much you appreciate their plugin and encourage them to continue to support it under the new plugin framework."
Brian WilkersonI like that! Is that something we add after the CL lands? Or we land it now, but leave hasPublishedDocs false until Parker publishes them to the website?
Brian WilkersonThe docs need to be landed first, with `hasPublishedDocs: false`, then Parker can publish them, then we can mark them as published. All of the CLs need to be cherry picked in order for the docs to be seen by 3.13 users.
But it's OK to have Connie look at them after the fact. We can update and re-publish them at any time without needing to cherry-pick them.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analyzer/lib/src/analysis_options/analysis_options_parse_model.dart
Insertions: 4, Deletions: 9.
@@ -273,15 +273,10 @@
reporter,
);
- if (analyzer.valueAt(AnalysisOptionsFileKeys.plugins) != null) {
- if (analyzer.getKey(AnalysisOptionsFileKeys.plugins)
- case var pluginsKeyNode?) {
- reporter.report(
- diag.analysisOptionsDeprecatedPlugins.atSourceSpan(
- pluginsKeyNode.span,
- ),
- );
- }
+ if (analyzer.getKey(AnalysisOptionsFileKeys.plugins) case var keyNode?) {
+ reporter.report(
+ diag.analysisOptionsDeprecatedPlugins.atSourceSpan(keyNode.span),
+ );
}
return _ParsedAnalyzerData._(
```
Change information
analyzer: Deprecate legacy analyzer plugins
Work towards https://github.com/dart-lang/sdk/issues/62164
- M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
- M pkg/analysis_server/lib/src/status/pages/legacy_plugins_page.dart
- M pkg/analyzer/lib/src/analysis_options/analysis_options_parse_model.dart
- M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
- M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
- M pkg/analyzer/messages.yaml
- M pkg/analyzer/test/src/analysis_options/analysis_options_parser_test.dart
Code-Review: +1 by Brian Wilkerson, +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |