[XS] Change in dart/sdk[main]: [gardening] Remove multiple_timer_test from isolate stress test suite.

2 views
Skip to first unread message

Alexander Aprelev (Gerrit)

unread,
Sep 26, 2025, 1:09:25 PM (3 days ago) Sep 26
to Alexander Aprelev, Brian Quinlan, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan

Alexander Aprelev voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Quinlan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1537fd4f12a8ff834c05f4e5defffd48f2009e42
Gerrit-Change-Number: 451800
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Attention: Brian Quinlan <bqui...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 17:09:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Sep 26, 2025, 4:13:12 PM (3 days ago) Sep 26
to Alexander Aprelev, Alexander Markov, Commit Queue, Brian Quinlan, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev and Brian Quinlan

Alexander Markov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
  • Brian Quinlan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1537fd4f12a8ff834c05f4e5defffd48f2009e42
Gerrit-Change-Number: 451800
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Attention: Brian Quinlan <bqui...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 20:13:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
Sep 26, 2025, 4:13:48 PM (3 days ago) Sep 26
to Alexander Aprelev, Alexander Markov, Commit Queue, Brian Quinlan, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan

Alexander Aprelev voted and added 1 comment

Votes added by Alexander Aprelev

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Aprelev . resolved

thanks Alex!

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Quinlan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1537fd4f12a8ff834c05f4e5defffd48f2009e42
Gerrit-Change-Number: 451800
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Attention: Brian Quinlan <bqui...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 20:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Sep 26, 2025, 4:14:06 PM (3 days ago) Sep 26
to Alexander Aprelev, Alexander Markov, Brian Quinlan, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[gardening] Remove multiple_timer_test from isolate stress test suite.

The test makes assumptions about timing making it unsuitable for isolate
stress testing bot.

Fixes https://github.com/dart-lang/sdk/issues/61592
TEST=ci
Change-Id: I1537fd4f12a8ff834c05f4e5defffd48f2009e42
Reviewed-by: Alexander Markov <alexm...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Files:
  • M runtime/tests/concurrency/stress_test_list.json
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Markov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I1537fd4f12a8ff834c05f4e5defffd48f2009e42
Gerrit-Change-Number: 451800
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages