[L] Change in dart/sdk[main]: [deps] Roll dart-lang/native
0 views
Skip to first unread message
Daco Harkes (Gerrit)
Feb 5, 2026, 12:46:24 PM (11 days ago) Feb 5
to Nate Biggs, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Feb 5, 2026, 9:19:30 PM (11 days ago) Feb 5
to Daco Harkes, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes
Nate Biggs voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Feb 6, 2026, 4:12:49 AM (11 days ago) Feb 6
to Nate Biggs, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Daco Harkes voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Feb 6, 2026, 4:13:07 AM (11 days ago) Feb 6
to Daco Harkes, Nate Biggs, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[deps] Roll dart-lang/native
Rolls in breaking changes to the JSON format and the Dart API for
`package:record_use`.
* Removed source locations.
* Map constants have a new representation.
* Some renamings.
TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dart2wasm/test/record_use_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart
Change-Id: Iaf42261b691e8400c87983fc5c46f69638cf59ec
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/478680
Commit-Queue: Daco Harkes <dacoh...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Files:
- M DEPS
- M pkg/compiler/lib/src/js_emitter/record_use_emitter.dart
- M pkg/compiler/lib/src/universe/recorded_use.dart
- M pkg/compiler/test/record_use/record_use_test.dart
- M pkg/vm/lib/transformations/record_use/record_call.dart
- M pkg/vm/lib/transformations/record_use/record_instance.dart
- M pkg/vm/lib/transformations/record_use/record_use.dart
- M pkg/vm/testcases/transformations/record_use/basic.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/complex.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/const_argument_instance.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/enum_const_arg.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/extension.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/instance_class.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/instance_complex.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/instance_duplicates.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/instance_not_annotation.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/loading_units_multiple.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/loading_units_simple.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/named_and_positional.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/named_both.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/named_optional.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/named_required.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/named_with_function_arg.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/nested.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/nested_instance_constant.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/partfile_main.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/positional_both.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/positional_both_with_type_argument.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/positional_optional.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/record_enum.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/record_instance_constant.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/record_instance_constant_empty.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/simple.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/tearoff.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/top_level_method.dart.json.expect
- M pkg/vm/testcases/transformations/record_use/types_of_arguments.dart.json.expect
Change size: L
Delta: 36 files changed, 89 insertions(+), 329 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Biggs
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Feb 9, 2026, 6:37:57 AM (7 days ago) Feb 9
to Nate Biggs, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Feb 9, 2026, 11:08:56 AM (7 days ago) Feb 9
to Daco Harkes, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes
Nate Biggs voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Feb 9, 2026, 11:23:00 AM (7 days ago) Feb 9
to Daco Harkes, Nate Biggs, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[deps] Roll dart-lang/native
Rolls in the unsupported constants breaking API change from
`package:record_use`. Unsupported constants implementation in stacked
CL.
TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dart2wasm/test/record_use_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart
Change-Id: I2f6b3cf32abf2b3a0426fe88a9ec20284348459e
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/478361
Reviewed-by: Nate Biggs <nate...@google.com>
Files:
- M DEPS
- M pkg/compiler/lib/src/universe/recorded_use.dart
- M pkg/dartdev/test/native_assets/compile_test.dart
- M pkg/vm/lib/transformations/record_use/record_call.dart
Change size: S
Delta: 4 files changed, 19 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Biggs
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Feb 12, 2026, 7:38:09 AM (4 days ago) Feb 12
to Nate Biggs, Michael Goderbauer, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Michael Goderbauer and Nate Biggs
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Goderbauer
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
Feb 12, 2026, 8:13:33 AM (4 days ago) Feb 12
to Nate Biggs, Michael Goderbauer, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Michael Goderbauer and Nate Biggs
Daco Harkes voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Michael Goderbauer (Gerrit)
Feb 12, 2026, 8:17:52 AM (4 days ago) Feb 12
to Daco Harkes, Nate Biggs, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes and Nate Biggs
Michael Goderbauer voted![]( "Open in Gerrit")
Attention is currently required from:
- Daco Harkes
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Feb 12, 2026, 8:18:06 AM (4 days ago) Feb 12
to Daco Harkes, Michael Goderbauer, Nate Biggs, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[deps] Roll dart-lang/native
TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dart2wasm/test/record_use_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart
Change-Id: Ie014ff428baed1e05d99f66ef041c745f98e04e2
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/479844
Reviewed-by: Michael Goderbauer <goder...@google.com>
Auto-Submit: Daco Harkes <dacoh...@google.com>
Commit-Queue: Michael Goderbauer <goder...@google.com>
Files:
- M DEPS
- M pkg/compiler/lib/src/js_emitter/record_use_emitter.dart
- M pkg/dartdev/test/native_assets/compile_test.dart
- M pkg/vm/lib/transformations/record_use/record_call.dart
- M pkg/vm/lib/transformations/record_use/record_instance.dart
- M pkg/vm/lib/transformations/record_use/record_use.dart
Change size: S
Delta: 6 files changed, 13 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Goderbauer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
10:19 AM (6 hours ago) 10:19 AM
to Michael Goderbauer, Nate Biggs, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Michael Goderbauer and Nate Biggs
Daco Harkes voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Goderbauer
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages