[M] Change in dart/sdk[main]: DevTools: Add a script that runs all of the DevTools tests
Samuel Rawlins (Gerrit)
Samuel Rawlins added 3 comments![]( "Open in Gerrit")
Hi Kenzie I have some open questions below. Let me know if you think anything needs to be addressed before landing this new script.
if 'RUNNER_OS' not in process_env:The `tool/ci/bots.sh` script currently uses this environment variable. Which is not how I would do this going forward, but I think it makes sense to sort of shoe-horn this new Python script into the existing script, and then when we make the SDK the primary/only development path for DevTools, we can clean this up. Does that sound right?
# Ensure tool/flutter-sdk exists in devtools_src for setup.sh.This symlink seems very strange to me. Do you know, @kenzie...@google.com if this is required (copied from GitHub CI workflow)? If it is, we can keep it and re-investigate after the Dart SDK becomes the way to develop devtools. (We can change this Python script and tool/ci/bots.sh atomically. And probably get rid of the latter for the former.)
Related details
- Kenzie Davisson
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
https://dart-review.googlesource.com/c/sdk/+/509061 is a pre-req, and I can add this script to the test matrix after that lands.
Related details
- Alexander Aprelev
- Kenzie Davisson
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |