Johnni Winther (Gerrit)

unread,

May 11, 2026, 3:16:34 AM (2 days ago) May 11

to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther voted and added 4 comments

Votes added by Johnni Winther

Code-Review

+1

4 comments

File pkg/analyzer/test/src/diagnostics/creation_with_non_type_test.dart

Line 433, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          diag.undefinedIdentifier,

Johnni Winther . unresolved

Preserve this TODO

Line 453, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          diag.undefinedIdentifier,

Johnni Winther . unresolved

Ditto.

Line 1280, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          text: "Undefined name 'unresolved'.",

Johnni Winther . unresolved

Ditto.

Line 1300, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          text: "Undefined name 'unresolved'.",

Johnni Winther . unresolved

Ditto.

Open in Gerrit

Related details

Attention is currently required from:

Konstantin Shcheglov
Paul Berry

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Konstantin Shcheglov (Gerrit)

unread,

May 12, 2026, 6:18:46 PM (15 hours ago) May 12

to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Paul Berry

Konstantin Shcheglov voted and added 4 comments

Votes added by Konstantin Shcheglov

Commit-Queue

+2

4 comments

File pkg/analyzer/test/src/diagnostics/creation_with_non_type_test.dart

Line 433, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          diag.undefinedIdentifier,

Johnni Winther . resolved

Preserve this TODO

Konstantin Shcheglov

Done

Line 453, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          diag.undefinedIdentifier,

Johnni Winther . resolved

Ditto.

Konstantin Shcheglov

Done

Line 1280, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          text: "Undefined name 'unresolved'.",

Johnni Winther . resolved

Ditto.

Konstantin Shcheglov

Done

Line 1300, Patchset 1 (Parent):

          // TODO(johnniwinther): This could be
          //  "Undefined prefix 'unresolved'.".
          text: "Undefined name 'unresolved'.",

Johnni Winther . resolved

Ditto.

Konstantin Shcheglov

Done

Open in Gerrit

Related details

Attention is currently required from:

Paul Berry

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Konstantin Shcheglov (Gerrit)

unread,

May 12, 2026, 8:12:45 PM (13 hours ago) May 12

to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Paul Berry

Konstantin Shcheglov voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Paul Berry

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

May 12, 2026, 9:07:25 PM (12 hours ago) May 12

to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: pkg/analyzer/test/src/diagnostics/creation_with_non_type_test.dart
Insertions: 4, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/test/src/diagnostics/class_used_as_mixin_test.dart
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. C.

Change-Id: I73cdfaf2e7d1ad17b386d851a058f31d42815077

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502520

Reviewed-by: Johnni Winther <johnni...@google.com>

Commit-Queue: Konstantin Shcheglov <sche...@google.com>

Files:

M pkg/analyzer/test/src/diagnostics/case_block_not_terminated_test.dart
M pkg/analyzer/test/src/diagnostics/case_expression_type_implements_equals_test.dart
M pkg/analyzer/test/src/diagnostics/case_expression_type_is_not_switch_expression_subtype_test.dart
M pkg/analyzer/test/src/diagnostics/cast_from_null_always_fails_test.dart
M pkg/analyzer/test/src/diagnostics/cast_to_non_type_test.dart
M pkg/analyzer/test/src/diagnostics/class_instantiation_access_to_member_test.dart
M pkg/analyzer/test/src/diagnostics/class_used_as_mixin_declares_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/class_used_as_mixin_test.dart
M pkg/analyzer/test/src/diagnostics/concrete_class_has_enum_superinterface_test.dart
M pkg/analyzer/test/src/diagnostics/concrete_class_with_abstract_member_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_constructor_and_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_constructor_and_static_method_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_field_and_method_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_generic_interfaces_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_inherited_method_and_setter_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_method_and_field_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_static_and_instance_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_type_variable_and_container_test.dart
M pkg/analyzer/test/src/diagnostics/conflicting_type_variable_and_member_test.dart
M pkg/analyzer/test/src/diagnostics/const_constructor_field_type_mismatch_test.dart
M pkg/analyzer/test/src/diagnostics/const_constructor_param_type_mismatch_test.dart
M pkg/analyzer/test/src/diagnostics/const_constructor_with_field_initialized_by_non_const_test.dart
M pkg/analyzer/test/src/diagnostics/const_constructor_with_mixin_with_field_test.dart
M pkg/analyzer/test/src/diagnostics/const_constructor_with_non_const_super_test.dart
M pkg/analyzer/test/src/diagnostics/const_constructor_with_non_final_field_test.dart
M pkg/analyzer/test/src/diagnostics/const_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_extension_method_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_for_element_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_method_invocation_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_primitive_equality_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_property_access_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_throws_exception_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_throws_idbze_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_type_bool_int_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_type_bool_num_string_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_type_bool_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_type_num_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_type_string_test.dart
M pkg/analyzer/test/src/diagnostics/const_field_initializer_not_assignable_test.dart
M pkg/analyzer/test/src/diagnostics/const_initialized_with_non_constant_value_from_deferred_library_test.dart
M pkg/analyzer/test/src/diagnostics/const_initialized_with_non_constant_value_test.dart
M pkg/analyzer/test/src/diagnostics/const_instance_field_test.dart
M pkg/analyzer/test/src/diagnostics/const_map_key_not_primitive_equality_test.dart
M pkg/analyzer/test/src/diagnostics/const_set_element_not_primitive_equality_test.dart
M pkg/analyzer/test/src/diagnostics/const_spread_expected_list_or_set_test.dart
M pkg/analyzer/test/src/diagnostics/const_spread_expected_map_test.dart
M pkg/analyzer/test/src/diagnostics/const_type_parameter_test.dart
M pkg/analyzer/test/src/diagnostics/const_with_non_const_test.dart
M pkg/analyzer/test/src/diagnostics/const_with_non_constant_argument_test.dart
M pkg/analyzer/test/src/diagnostics/const_with_non_type_test.dart
M pkg/analyzer/test/src/diagnostics/const_with_type_parameters_test.dart
M pkg/analyzer/test/src/diagnostics/const_with_undefined_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/constant_pattern_never_matches_value_type_test.dart
M pkg/analyzer/test/src/diagnostics/constant_pattern_with_non_constant_expression_test.dart
M pkg/analyzer/test/src/diagnostics/constructor_body_test.dart
M pkg/analyzer/test/src/diagnostics/continue_label_invalid_test.dart
M pkg/analyzer/test/src/diagnostics/could_not_infer_test.dart
M pkg/analyzer/test/src/diagnostics/creation_of_struct_or_union_test.dart
M pkg/analyzer/test/src/diagnostics/creation_with_non_type_test.dart

Change size: XL

Delta: 59 files changed, 3189 insertions(+), 4510 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Johnni Winther

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. C.

Johnni Winther (Gerrit)

Johnni Winther voted and added 4 comments

Votes added by Johnni Winther

4 comments

Related details

Konstantin Shcheglov (Gerrit)

Konstantin Shcheglov voted and added 4 comments

Votes added by Konstantin Shcheglov

4 comments

Related details

Konstantin Shcheglov (Gerrit)

Konstantin Shcheglov voted Commit-Queue+2

Related details

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

Change information