[M] Change in dart/sdk[main]: Look at export statements too for replaceBy transform

0 views
Skip to first unread message

Keerti Parthasarathy (Gerrit)

unread,
2:53 PM (4 hours ago) 2:53 PM
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I444e176e263e62763dbb67492fea857366d4f8a9
Gerrit-Change-Number: 532040
Gerrit-PatchSet: 3
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 18:53:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
4:02 PM (3 hours ago) 4:02 PM
to Keerti Parthasarathy, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I444e176e263e62763dbb67492fea857366d4f8a9
Gerrit-Change-Number: 532040
Gerrit-PatchSet: 4
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 20:00:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
4:07 PM (3 hours ago) 4:07 PM
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Keerti Parthasarathy voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I444e176e263e62763dbb67492fea857366d4f8a9
Gerrit-Change-Number: 532040
Gerrit-PatchSet: 4
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 20:07:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
4:07 PM (3 hours ago) 4:07 PM
to Keerti Parthasarathy, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Look at export statements too for replaceBy transform

Fixes https://github.com/dart-lang/sdk/issues/63968
Change-Id: I444e176e263e62763dbb67492fea857366d4f8a9
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
  • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/code_template.dart
  • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart
  • M pkg/analysis_server/lib/src/services/correction/fix/data_driven/replaced_by.dart
  • M pkg/analysis_server/test/src/services/correction/fix/data_driven/flutter_use_case_test.dart
Change size: M
Delta: 4 files changed, 53 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I444e176e263e62763dbb67492fea857366d4f8a9
Gerrit-Change-Number: 532040
Gerrit-PatchSet: 5
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages