[M] Change in dart/sdk[main]: [cfe] Use AST node getters for the new variable model

0 views
Skip to first unread message

Chloe Stefantsova (Gerrit)

unread,
Mar 9, 2026, 7:40:58 AM (19 hours ago) Mar 9
to Chloe Stefantsova, Johnni Winther, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova added 1 comment

File pkg/front_end/lib/src/kernel/internal_ast.dart
Line 1515, Patchset 1: astVariable.type = value;
Chloe Stefantsova . resolved

This bugfix is unrelated to the overall subject of the CL, but separating it out into its own CL felt burdensome.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0984d076b9b9591c62fb91238a4df08c4eb9b414
Gerrit-Change-Number: 486200
Gerrit-PatchSet: 2
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 11:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Mar 9, 2026, 8:15:18 AM (19 hours ago) Mar 9
to Chloe Stefantsova, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chloe Stefantsova
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0984d076b9b9591c62fb91238a4df08c4eb9b414
Gerrit-Change-Number: 486200
Gerrit-PatchSet: 2
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 12:15:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chloe Stefantsova (Gerrit)

unread,
Mar 9, 2026, 8:19:32 AM (19 hours ago) Mar 9
to Chloe Stefantsova, Johnni Winther, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org

Chloe Stefantsova voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0984d076b9b9591c62fb91238a4df08c4eb9b414
Gerrit-Change-Number: 486200
Gerrit-PatchSet: 2
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 12:19:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 9, 2026, 8:19:50 AM (19 hours ago) Mar 9
to Chloe Stefantsova, Johnni Winther, dart-fe-te...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[cfe] Use AST node getters for the new variable model

This CL migrates CFE to use the getters of the Kernel AST nodes with
return types of the new variable model.

Part of https://github.com/dart-lang/sdk/issues/61572
Change-Id: I0984d076b9b9591c62fb91238a4df08c4eb9b414
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Chloe Stefantsova <cstefa...@google.com>
Files:
  • M pkg/front_end/lib/src/base/incremental_compiler.dart
  • M pkg/front_end/lib/src/kernel/const_conditional_simplifier.dart
  • M pkg/front_end/lib/src/kernel/constant_evaluator.dart
  • M pkg/front_end/lib/src/kernel/internal_ast.dart
  • M pkg/front_end/lib/src/testing/id_extractor.dart
  • M pkg/front_end/lib/src/type_inference/for_in.dart
  • M pkg/front_end/lib/src/type_inference/inference_visitor.dart
  • M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart
  • M pkg/front_end/test/id_tests/nullability_test.dart
  • M pkg/front_end/testcases/closure_context_lowering/catch_variables.dart.strong.expect
  • M pkg/front_end/testcases/closure_context_lowering/catch_variables.dart.strong.modular.expect
  • M pkg/front_end/tool/unreachable_if_finder.dart
Change size: M
Delta: 12 files changed, 48 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Johnni Winther
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0984d076b9b9591c62fb91238a4df08c4eb9b414
Gerrit-Change-Number: 486200
Gerrit-PatchSet: 3
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages