[M] Change in dart/sdk[main]: [tests] Variance - out and inout are built-in identifiers.
0 views
Skip to first unread message
Kallen Tu (Gerrit)
Mar 6, 2026, 7:58:08 PM (3 days ago) Mar 6
to Erik Ernst, Commit Queue, rev...@dartlang.org
Attention needed from Erik Ernst
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Erik Ernst
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Ernst (Gerrit)
Mar 9, 2026, 4:17:45 AM (23 hours ago) Mar 9
to Kallen Tu, Commit Queue, rev...@dartlang.org
Attention needed from Kallen Tu
Erik Ernst voted and added 2 comments![]( "Open in Gerrit")
Votes added by Erik Ernst
| Code-Review | +1 |
2 comments
Patchset-level comments
File tests/language/variance/syntax/variance_builtin_identifier_syntax_test.dart
Line 32, Patchset 3 (Latest):
Expect.equals(5, out);Erik Ernst . unresolved
Add a couple of cases using `inout`?
Related details
Attention is currently required from:
- Kallen Tu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Mar 9, 2026, 3:38:51 PM (11 hours ago) Mar 9
to Erik Ernst, Commit Queue, rev...@dartlang.org
Kallen Tu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Mar 9, 2026, 3:38:55 PM (11 hours ago) Mar 9
to Erik Ernst, Commit Queue, rev...@dartlang.org
Kallen Tu added 1 comment![]( "Open in Gerrit")
File tests/language/variance/syntax/variance_builtin_identifier_syntax_test.dart
Add a couple of cases using `inout`?
Kallen Tu
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 9, 2026, 4:19:20 PM (11 hours ago) Mar 9
to Kallen Tu, Erik Ernst, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tests/language/variance/syntax/variance_builtin_identifier_syntax_test.dart
Insertions: 18, Deletions: 0.
@@ -20,14 +20,32 @@
int out() => 1;
}
+class InoutMembers {
+ var inout = 3;
+ int func(int inout) {
+ return inout;
+ }
+}
+
+class InoutMethod {
+ int inout() => 1;
+}
+
var out = 5;
+var inout = 5;
main() {
OutMembers outMembers = OutMembers();
Expect.equals(2, outMembers.func(2));
Expect.equals(3, outMembers.out);
+ InoutMembers inoutMembers = InoutMembers();
+ Expect.equals(2, inoutMembers.func(2));
+ Expect.equals(3, inoutMembers.inout);
+
Expect.equals(1, OutMethod().out());
+ Expect.equals(1, InoutMethod().inout());
Expect.equals(5, out);
+ Expect.equals(5, inout);
}
```
Change information
Commit message:
[tests] Variance - out and inout are built-in identifiers.
Updating language tests to mark `inout` and `out` as built-in identifiers. They should produce a compile-time error if used as a type name.
Bug: https://github.com/dart-lang/language/issues/524
Change-Id: Ibdefb1090ecdd64c2bee4dcb7cc5ec8708455fcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/486341
Reviewed-by: Erik Ernst <eer...@google.com>
Commit-Queue: Kallen Tu <kall...@google.com>
Files:
- A tests/language/variance/syntax/variance_builtin_identifier_syntax_error_test.dart
- A tests/language/variance/syntax/variance_builtin_identifier_syntax_test.dart
- R tests/language/variance/syntax/variance_disabled_builtin_identifier_syntax_test.dart
- D tests/language/variance/syntax/variance_keyword_identifier_syntax_test.dart
Change size: M
Delta: 4 files changed, 113 insertions(+), 57 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Erik Ernst
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages