[S] Change in dart/sdk[main]: Implement a visitor method for DotShorthandInvocation to ExitDetector.

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Oct 20, 2025, 7:52:08 PM (17 hours ago) Oct 20
to Fedor Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie0d10e2e889fcf657eaa8461a362a75587d5b0ff
Gerrit-Change-Number: 456162
Gerrit-PatchSet: 5
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 23:52:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Oct 20, 2025, 8:08:46 PM (17 hours ago) Oct 20
to Fedor Shcheglov, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0d10e2e889fcf657eaa8461a362a75587d5b0ff
    Gerrit-Change-Number: 456162
    Gerrit-PatchSet: 5
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Tue, 21 Oct 2025 00:08:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Oct 20, 2025, 8:23:33 PM (17 hours ago) Oct 20
    to Fedor Shcheglov, Paul Berry, Johnni Winther, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov, Johnni Winther and Paul Berry

    Konstantin Shcheglov voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    • Johnni Winther
    • Paul Berry
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0d10e2e889fcf657eaa8461a362a75587d5b0ff
    Gerrit-Change-Number: 456162
    Gerrit-PatchSet: 5
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Comment-Date: Tue, 21 Oct 2025 00:23:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Oct 20, 2025, 8:23:48 PM (17 hours ago) Oct 20
    to Fedor Shcheglov, Paul Berry, Johnni Winther, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov, Johnni Winther and Paul Berry

    Konstantin Shcheglov voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Tue, 21 Oct 2025 00:23:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Oct 20, 2025, 8:24:28 PM (17 hours ago) Oct 20
    to Fedor Shcheglov, Paul Berry, Johnni Winther, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    Implement a visitor method for DotShorthandInvocation to ExitDetector.
    Change-Id: Ie0d10e2e889fcf657eaa8461a362a75587d5b0ff
    Commit-Queue: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Files:
    • M pkg/analyzer/lib/src/dart/resolver/exit_detector.dart
    • M pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart
    Change size: S
    Delta: 2 files changed, 42 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie0d10e2e889fcf657eaa8461a362a75587d5b0ff
    Gerrit-Change-Number: 456162
    Gerrit-PatchSet: 6
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages