[M] Change in dart/sdk[main]: Replace skipped with failing for tests
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Jun 23, 2026, 5:27:32 PM (7 hours ago) Jun 23
to Brian Wilkerson, Samuel Rawlins, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jun 23, 2026, 6:12:46 PM (6 hours ago) Jun 23
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved
This is very nice! Excellent to see so many tests can just be enabled.
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jun 23, 2026, 6:12:54 PM (6 hours ago) Jun 23
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Jun 23, 2026, 7:06:21 PM (5 hours ago) Jun 23
to Brian Wilkerson, Samuel Rawlins, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 7:06:30 PM (5 hours ago) Jun 23
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace skipped with failing for tests
This replaces the use of `SkippedTest` with `FailingTest` everywhere
that the test currently fails. In places where is isn't failing it
just removes the `SkippedTest`.
And in a couple of places where the switch had been done in a previous
CL, this adds an issue that can be used to track the work to fix them.
Change-Id: I0e6554857c900a8b132ab6969fdee71a6c025965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/516382
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/linter/test/rules/annotate_redeclares_test.dart
- M pkg/linter/test/rules/avoid_field_initializers_in_non_const_classes_test.dart
- M pkg/linter/test/rules/avoid_renaming_method_parameters_test.dart
- M pkg/linter/test/rules/camel_case_types_test.dart
- M pkg/linter/test/rules/constant_identifier_names_test.dart
- M pkg/linter/test/rules/one_member_abstracts_test.dart
- M pkg/linter/test/rules/overridden_fields_test.dart
- M pkg/linter/test/rules/prefer_typing_uninitialized_variables_test.dart
- M pkg/linter/test/rules/type_annotate_public_apis_test.dart
- M pkg/linter/test/rules/use_key_in_widget_constructors_test.dart
Change size: M
Delta: 10 files changed, 44 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages