[XL] Change in dart/sdk[main]: [analyzer/linter] Clean up error message comments.
0 views
Skip to first unread message
Paul Berry (Gerrit)
Aug 7, 2025, 6:32:29 PM8/7/25
to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Johnni Winther and Konstantin Shcheglov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brian Wilkerson
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Aug 7, 2025, 8:15:34 PM8/7/25
to Paul Berry, Brian Wilkerson, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Johnni Winther and Paul Berry
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Aug 8, 2025, 2:35:13 AM8/8/25
to Paul Berry, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Aug 8, 2025, 9:31:18 AM8/8/25
to Phil Quitslund, Johnni Winther, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Phil Quitslund
Paul Berry added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Paul Berry . resolved
Phil, can you take a look at the pkg/linter changes, since Brian is out today?
Related details
Attention is currently required from:
- Brian Wilkerson
- Phil Quitslund
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Quitslund (Gerrit)
Aug 10, 2025, 1:28:50 PM8/10/25
to Paul Berry, Johnni Winther, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Paul Berry
Phil Quitslund voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Aug 11, 2025, 9:01:35 AM8/11/25
to Phil Quitslund, Johnni Winther, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Paul Berry voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 11, 2025, 9:39:59 AM8/11/25
to Paul Berry, Phil Quitslund, Johnni Winther, Konstantin Shcheglov, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[analyzer/linter] Clean up error message comments.
This change modifies the comments in the analyzer and linter
`messages.yaml` files so that:
- Parameters are always described at the end of the comment. If the
message takes no parameters, the comment ends with the text `No
parameters.`
- Parameter descriptions are always word wrapped to 80 columns.
It also fixes the format of the comment field for
`ANALYSIS_OPTION_DEPRECATED` to remove an unintentional blank line,
and adds documentation for the second parameter of
`INVALID_EXPORT_OF_INTERNAL_ELEMENT_INDIRECTLY` (which was previously
missing).
In a follow-up CL, I will transition to a more structured format for
parameters in these `messages.yaml` files, and the `Parameters:`
sections of the comments will be automatically generated from this
structured format during code generation. Cleaning up the comments now
will ensure that the follow-up CL is clean (makes no changes to
generated files), so we'll be able to have high confidence in its
correctness.
Change-Id: I6aa1f75fa0b8e4fb9724dcba00fb7d1f06dfb355
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444205
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
Files:
- M pkg/_fe_analyzer_shared/lib/src/scanner/errors.g.dart
- M pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart
- M pkg/analyzer/lib/src/dart/error/ffi_code.g.dart
- M pkg/analyzer/lib/src/dart/error/hint_codes.g.dart
- M pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart
- M pkg/analyzer/lib/src/error/codes.g.dart
- M pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart
- M pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart
- M pkg/analyzer/messages.yaml
- M pkg/linter/lib/src/lint_codes.g.dart
- M pkg/linter/messages.yaml
Change size: XL
Delta: 11 files changed, 1357 insertions(+), 132 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther, +1 by Phil Quitslund, +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages