[M] Change in dart/sdk[main]: [DAS] Fixes renaming constructor invocation on annotation
FMorschel (Gerrit)
FMorschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[DAS] Fixes renaming constructor invocation on annotation
Change information
- M pkg/analysis_server/test/services/refactoring/legacy/rename_constructor_test.dart
- M pkg/analyzer/lib/src/dart/analysis/index.dart
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
FMorschel (Gerrit)
FMorschel added 1 comment![]( "Open in Gerrit")
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
if (parent case Annotation(Changes to `index.dart` should be paired with changes to `index_test.dart`, providing full coverage for the new logic.
Related details
- Brian Wilkerson
- FMorschel
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
FMorschel (Gerrit)
FMorschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by FMorschel
| Auto-Submit | +1 |
1 comment
Changes to `index.dart` should be paired with changes to `index_test.dart`, providing full coverage for the new logic.
I've updated the tests that failed. They already covered the changes.
PTAL again. Thanks!
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
107 9:2 |A| IS_INVOKED_BYThese changes don't make sense.
Class name is referenced.
Constructors (in annotation) are invoked.
Classes cannot be invoked.
Related details
- Brian Wilkerson
- FMorschel
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
107 9:2 |A| IS_INVOKED_BYThese changes don't make sense.
Class name is referenced.
Constructors (in annotation) are invoked.
Classes cannot be invoked.
Related details
- Brian Wilkerson
- FMorschel
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
107 9:2 |A| IS_INVOKED_BYThese changes don't make sense.
Class name is referenced.
Constructors (in annotation) are invoked.
Classes cannot be invoked.
Also, these changes are potentially breaking. If there's a refactoring that's looking for all the places a class `IS_REFERENCED_BY`, then it will no longer find these locations.
I haven't tried running all of the `analyzer` and `analysis_server` tests with these changes patched in. I don't know whether you have, but it would be worth a try.
But there's a bigger question. As far as I can tell this didn't add any information to the index, just changed the relationship being recorded in a few places. So why did that help?
Related details
- FMorschel
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |