[L] Change in dart/sdk[main]: [cfe,vm,dart2bytecode] Rename Variable into BaseVariable, ExpressionV...
0 views
Skip to first unread message
Chloe Stefantsova (Gerrit)
Mar 13, 2026, 7:50:59 AMMar 13
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov and Johnni Winther
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Markov
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Mar 13, 2026, 8:15:59 AMMar 13
to Chloe Stefantsova, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov and Chloe Stefantsova
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
- Chloe Stefantsova
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Mar 13, 2026, 8:40:21 AMMar 13
to Chloe Stefantsova, Alexander Markov, Johnni Winther, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova
Alexander Markov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Chloe Stefantsova
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
Mar 13, 2026, 8:41:55 AMMar 13
to Chloe Stefantsova, Alexander Markov, Johnni Winther, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Chloe Stefantsova voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 13, 2026, 8:42:09 AMMar 13
to Chloe Stefantsova, Alexander Markov, Johnni Winther, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[cfe,vm,dart2bytecode] Rename Variable into BaseVariable, ExpressionVariable into Variable
This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/487381/comment/3eb20545_b37553c4/
Part of https://github.com/dart-lang/sdk/issues/61572
TEST=existing
Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487800
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Chloe Stefantsova <cstefa...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
- M pkg/dart2bytecode/lib/bytecode_generator.dart
- M pkg/dart2bytecode/lib/local_vars.dart
- M pkg/front_end/lib/src/api_prototype/lowering_predicates.dart
- M pkg/front_end/lib/src/base/incremental_compiler.dart
- M pkg/front_end/lib/src/builder/formal_parameter_builder.dart
- M pkg/front_end/lib/src/builder/variable_builder.dart
- M pkg/front_end/lib/src/kernel/assigned_variables_impl.dart
- M pkg/front_end/lib/src/kernel/body_builder.dart
- M pkg/front_end/lib/src/kernel/body_builder_helpers.dart
- M pkg/front_end/lib/src/kernel/collections.dart
- M pkg/front_end/lib/src/kernel/const_conditional_simplifier.dart
- M pkg/front_end/lib/src/kernel/constant_evaluator.dart
- M pkg/front_end/lib/src/kernel/expression_generator.dart
- M pkg/front_end/lib/src/kernel/expression_generator_helper.dart
- M pkg/front_end/lib/src/kernel/forest.dart
- M pkg/front_end/lib/src/kernel/internal_ast.dart
- M pkg/front_end/lib/src/kernel/kernel_variable_builder.dart
- M pkg/front_end/lib/src/kernel/resolver.dart
- M pkg/front_end/lib/src/type_inference/context_allocation_strategy.dart
- M pkg/front_end/lib/src/type_inference/delayed_expressions.dart
- M pkg/front_end/lib/src/type_inference/external_ast_helper.dart
- M pkg/front_end/lib/src/type_inference/for_in.dart
- M pkg/front_end/lib/src/type_inference/inference_visitor.dart
- M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart
- M pkg/front_end/lib/src/type_inference/type_constraint_gatherer.dart
- M pkg/front_end/lib/src/type_inference/type_inference_engine.dart
- M pkg/front_end/lib/src/type_inference/type_inferrer.dart
- M pkg/front_end/lib/src/type_inference/type_schema_environment.dart
- M pkg/front_end/test/id_tests/assigned_variables_test.dart
- M pkg/front_end/tool/unreachable_if_finder.dart
- M pkg/kernel/lib/clone.dart
- M pkg/kernel/lib/src/ast/expressions.dart
- M pkg/kernel/lib/src/ast/patterns.dart
- M pkg/kernel/lib/src/ast/statements.dart
- M pkg/kernel/lib/src/ast/types.dart
- M pkg/kernel/lib/src/ast/variables.dart
- M pkg/kernel/lib/src/equivalence.dart
- M pkg/kernel/lib/src/printer.dart
- M pkg/kernel/lib/text/ast_to_text.dart
- M pkg/kernel/lib/verifier.dart
- M pkg/vm/lib/modular/transformations/for_in_lowering.dart
Change size: L
Delta: 41 files changed, 294 insertions(+), 321 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov, +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages