[L] Change in dart/sdk[main]: [cfe,vm,dart2bytecode] Rename Variable into BaseVariable, ExpressionV...

0 views
Skip to first unread message

Chloe Stefantsova (Gerrit)

unread,
Mar 13, 2026, 7:50:59 AMMar 13
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov and Johnni Winther

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
  • Johnni Winther
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
Gerrit-Change-Number: 487800
Gerrit-PatchSet: 1
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 11:50:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Mar 13, 2026, 8:15:59 AMMar 13
to Chloe Stefantsova, Alexander Markov, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Alexander Markov and Chloe Stefantsova

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
  • Chloe Stefantsova
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
    Gerrit-Change-Number: 487800
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-CC: Jens Johansen <je...@google.com>
    Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Attention: Alexander Markov <alexm...@google.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 12:15:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Alexander Markov (Gerrit)

    unread,
    Mar 13, 2026, 8:40:21 AMMar 13
    to Chloe Stefantsova, Alexander Markov, Johnni Winther, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
    Attention needed from Chloe Stefantsova

    Alexander Markov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chloe Stefantsova
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
    Gerrit-Change-Number: 487800
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-CC: Jens Johansen <je...@google.com>
    Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 12:40:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chloe Stefantsova (Gerrit)

    unread,
    Mar 13, 2026, 8:41:55 AMMar 13
    to Chloe Stefantsova, Alexander Markov, Johnni Winther, Commit Queue, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org

    Chloe Stefantsova voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedCommit-Message-Has-TEST
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
      Gerrit-Change-Number: 487800
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
      Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
      Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-CC: Jens Johansen <je...@google.com>
      Gerrit-Comment-Date: Fri, 13 Mar 2026 12:41:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Commit Queue (Gerrit)

      unread,
      Mar 13, 2026, 8:42:09 AMMar 13
      to Chloe Stefantsova, Alexander Markov, Johnni Winther, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org

      Commit Queue submitted the change

      Unreviewed changes

      1 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      [cfe,vm,dart2bytecode] Rename Variable into BaseVariable, ExpressionVariable into Variable

      This is a follow-up to
      https://dart-review.googlesource.com/c/sdk/+/487381/comment/3eb20545_b37553c4/

      Part of https://github.com/dart-lang/sdk/issues/61572

      TEST=existing
      Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
      Reviewed-by: Johnni Winther <johnni...@google.com>
      Commit-Queue: Chloe Stefantsova <cstefa...@google.com>
      Reviewed-by: Alexander Markov <alexm...@google.com>
      Files:
      • M pkg/dart2bytecode/lib/bytecode_generator.dart
      • M pkg/dart2bytecode/lib/local_vars.dart
      • M pkg/front_end/lib/src/api_prototype/lowering_predicates.dart
      • M pkg/front_end/lib/src/base/incremental_compiler.dart
      • M pkg/front_end/lib/src/builder/formal_parameter_builder.dart
      • M pkg/front_end/lib/src/builder/variable_builder.dart
      • M pkg/front_end/lib/src/kernel/assigned_variables_impl.dart
      • M pkg/front_end/lib/src/kernel/body_builder.dart
      • M pkg/front_end/lib/src/kernel/body_builder_helpers.dart
      • M pkg/front_end/lib/src/kernel/collections.dart
      • M pkg/front_end/lib/src/kernel/const_conditional_simplifier.dart
      • M pkg/front_end/lib/src/kernel/constant_evaluator.dart
      • M pkg/front_end/lib/src/kernel/expression_generator.dart
      • M pkg/front_end/lib/src/kernel/expression_generator_helper.dart
      • M pkg/front_end/lib/src/kernel/forest.dart
      • M pkg/front_end/lib/src/kernel/internal_ast.dart
      • M pkg/front_end/lib/src/kernel/kernel_variable_builder.dart
      • M pkg/front_end/lib/src/kernel/resolver.dart
      • M pkg/front_end/lib/src/type_inference/context_allocation_strategy.dart
      • M pkg/front_end/lib/src/type_inference/delayed_expressions.dart
      • M pkg/front_end/lib/src/type_inference/external_ast_helper.dart
      • M pkg/front_end/lib/src/type_inference/for_in.dart
      • M pkg/front_end/lib/src/type_inference/inference_visitor.dart
      • M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart
      • M pkg/front_end/lib/src/type_inference/type_constraint_gatherer.dart
      • M pkg/front_end/lib/src/type_inference/type_inference_engine.dart
      • M pkg/front_end/lib/src/type_inference/type_inferrer.dart
      • M pkg/front_end/lib/src/type_inference/type_schema_environment.dart
      • M pkg/front_end/test/id_tests/assigned_variables_test.dart
      • M pkg/front_end/tool/unreachable_if_finder.dart
      • M pkg/kernel/lib/clone.dart
      • M pkg/kernel/lib/src/ast/expressions.dart
      • M pkg/kernel/lib/src/ast/patterns.dart
      • M pkg/kernel/lib/src/ast/statements.dart
      • M pkg/kernel/lib/src/ast/types.dart
      • M pkg/kernel/lib/src/ast/variables.dart
      • M pkg/kernel/lib/src/equivalence.dart
      • M pkg/kernel/lib/src/printer.dart
      • M pkg/kernel/lib/text/ast_to_text.dart
      • M pkg/kernel/lib/verifier.dart
      • M pkg/vm/lib/modular/transformations/for_in_lowering.dart
      Change size: L
      Delta: 41 files changed, 294 insertions(+), 321 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Alexander Markov, +1 by Johnni Winther
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I15c7438dcec3d412f3050d3d80517d5cff5b515f
      Gerrit-Change-Number: 487800
      Gerrit-PatchSet: 3
      Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
      Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
      Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-CC: Jens Johansen <je...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages