[S] Change in dart/sdk[main]: [Service] dap_adapters: Add LICENSE and rename main library
0 views
Skip to first unread message
Ben Konyi (Gerrit)
Aug 4, 2026, 2:32:23 PM (yesterday) Aug 4
to rev...@dartlang.org
Ben Konyi has uploaded the change for review![]( "Open in Gerrit")
Commit message
[Service] dap_adapters: Add LICENSE and rename main library
Address package validation comments for package:dap_adapters:
- Add LICENSE file to the root of the package.
- Rename lib/dap.dart to lib/dap_adapters.dart to match the package name, and update all references.
Change-Id: If13fc4936535a6b0f360b4020e329902266b0cf5
Change information
Files:
- A pkg/dap_adapters/LICENSE
- M pkg/dap_adapters/analysis_options.yaml
- R pkg/dap_adapters/lib/dap_adapters.dart
- M pkg/dap_adapters/lib/src/protocol_converter.dart
- M pkg/dap_adapters/test/dap/arguments_test.dart
- M pkg/dap_adapters/test/dap/dart_cli_test.dart
- M pkg/dap_adapters/test/dap/dart_test_test.dart
- M pkg/dap_adapters/test/dap/mocks.dart
- M pkg/dartdev/lib/src/commands/debug_adapter.dart
- M pkg/dds/lib/dap.dart
- M pkg/dds/lib/src/client.dart
- M pkg/dds/lib/src/dap_handler.dart
- M pkg/dds/test/dap_handler_test.dart
Change size: S
Delta: 13 files changed, 38 insertions(+), 11 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Aug 4, 2026, 2:34:43 PM (yesterday) Aug 4
to Nicholas Shahan, Mark Zhou, rev...@dartlang.org
Attention needed from Mark Zhou and Nicholas Shahan
Ben Konyi voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mark Zhou
- Nicholas Shahan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Shahan (Gerrit)
11:22 AM (8 hours ago) 11:22 AM
to Ben Konyi, dart-...@luci-project-accounts.iam.gserviceaccount.com, Mark Zhou, rev...@dartlang.org
Attention needed from Ben Konyi and Mark Zhou
Nicholas Shahan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Shahan
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nicholas Shahan . resolved
There is a package of adapters for the adapter protocol? 😵💫
Related details
Attention is currently required from:
- Ben Konyi
- Mark Zhou
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
11:38 AM (7 hours ago) 11:38 AM
to Nicholas Shahan, dart-...@luci-project-accounts.iam.gserviceaccount.com, Mark Zhou, rev...@dartlang.org
Attention needed from Mark Zhou
Ben Konyi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nicholas Shahan . resolved
There is a package of adapters for the adapter protocol? 😵💫
Ben Konyi
Yes, these are the adapters implementing the Debug Adapter Protocol 😄
Related details
Attention is currently required from:
- Mark Zhou
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Zhou (Gerrit)
1:12 PM (6 hours ago) 1:12 PM
to Ben Konyi, Nicholas Shahan, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Ben Konyi
Mark Zhou voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ben Konyi
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
2:46 PM (4 hours ago) 2:46 PM
to Mark Zhou, Nicholas Shahan, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Ben Konyi submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Service] dap_adapters: Add LICENSE and rename main library
Address package validation comments for package:dap_adapters:
- Add LICENSE file to the root of the package.
- Rename lib/dap.dart to lib/dap_adapters.dart to match the package name, and update all references.
Change-Id: If13fc4936535a6b0f360b4020e329902266b0cf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/531280
Reviewed-by: Nicholas Shahan <nsh...@google.com>
Auto-Submit: Ben Konyi <bko...@google.com>
Reviewed-by: Mark Zhou <mark...@google.com>
Files:
- A pkg/dap_adapters/LICENSE
- M pkg/dap_adapters/analysis_options.yaml
- R pkg/dap_adapters/lib/dap_adapters.dart
- M pkg/dap_adapters/lib/src/protocol_converter.dart
- M pkg/dap_adapters/test/dap/arguments_test.dart
- M pkg/dap_adapters/test/dap/dart_cli_test.dart
- M pkg/dap_adapters/test/dap/dart_test_test.dart
- M pkg/dap_adapters/test/dap/mocks.dart
- M pkg/dartdev/lib/src/commands/debug_adapter.dart
- M pkg/dds/lib/dap.dart
- M pkg/dds/lib/src/client.dart
- M pkg/dds/lib/src/dap_handler.dart
- M pkg/dds/test/dap_handler_test.dart
Change size: S
Delta: 13 files changed, 38 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicholas Shahan, +1 by Mark Zhou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages